This repository was archived by the owner on Dec 3, 2025. It is now read-only.
#21 - Pet Preferences Selection Page #51
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
EwelinaSkrzypacz
left a comment
EwelinaSkrzypacz
left a comment
There was a problem hiding this comment.
I logged as a [email protected] -> I go to "Zwierzęta" -> I see error
Btw. I think that not authenticated user should also see page with pets 👀
Member
|
Conflicts 👀 |
…eController and tests, drop JS entrypoint in favor of app.ts
Member
|
@TomaszRebizant conflicts |
TomaszRebizant
requested review from
AleksandraKozubal and
EwelinaSkrzypacz
Member
AleksandraKozubal
left a comment
AleksandraKozubal
left a comment
There was a problem hiding this comment.
Please check my old comments, they're not resolved yet
TomaszRebizant
requested review from
AleksandraKozubal and
EwelinaSkrzypacz
EwelinaSkrzypacz
previously approved these changes
Sep 17, 2025
| use Illuminate\Database\Eloquent\Factories\HasFactory; | ||
| use Illuminate\Database\Eloquent\Model; | ||
| use Illuminate\Database\Eloquent\Relations\BelongsToMany; | ||
|
|
Member
There was a problem hiding this comment.
Suggested change
| /** | |
| * @property string $name | |
| * @property-read Collection<int, Pet> $pets | |
| */ |
Also add * @property-read Collection<int, Tag> $tags to Pet model
| continue; | ||
| } | ||
| $list = array_is_list($prefValues) ? $prefValues : [$prefValues]; | ||
| $normalized[$field] = array_values(array_filter($list, static fn($p) => is_array($p) && (array_key_exists("value", $p) || array_key_exists("weight", $p)))); |
| return Inertia::render("Dashboard/Dashboard", [ | ||
| "pets" => PetMatchResource::collection($pets)->resolve(), | ||
| $tags = Tag::query() | ||
| ->withCount(["pets as accepted_pets_count" => fn($q) => $q->where("is_accepted", true)]) |
| "pets" => PetMatchResource::collection($pets)->resolve(), | ||
| $tags = Tag::query() | ||
| ->withCount(["pets as accepted_pets_count" => fn($q) => $q->where("is_accepted", true)]) | ||
| ->whereHas("pets", fn($q) => $q->where("is_accepted", true), ">", 1) |
| "count" => (int)$tag->accepted_pets_count, | ||
| ]); | ||
|
|
||
| $breedQuery = fn(string $species) => Pet::query() |
Member
|
@TomaszRebizant conflicts |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should close #21