This repository was archived by the owner on Dec 3, 2025. It is now read-only.
#51 - map of events #56
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # .env.ci # .php-cs-fixer.cache # app/Enums/Role.php # app/Http/Controllers/LoginController.php # app/Http/Controllers/RegisterController.php # app/Http/Controllers/ResetPasswordController.php # app/Http/Middleware/SetLocaleMiddleware.php # app/Http/Requests/LoginRequest.php # app/Http/Requests/PasswordResetLinkRequest.php # app/Http/Requests/RegisterRequest.php # app/Http/Requests/ResetPasswordRequest.php # app/Models/User.php # config/app.php # config/cors.php # config/permission.php # database/factories/UserFactory.php # database/migrations/0001_01_01_000000_create_users_table.php # database/migrations/2025_06_12_105434_create_permission_tables.php # database/migrations/2025_06_16_070140_create_activity_log_table.php # database/seeders/DatabaseSeeder.php # database/seeders/RoleSeeder.php # lang/en/auth.php # lang/en/passwords.php # lang/pl/auth.php # lang/pl/passwords.php # phpunit.xml # routes/api.php # tests/Feature/ForgotPasswordTest.php # tests/Feature/LoginUserTest.php # tests/Feature/LogoutUserTest.php # tests/Feature/RegisterUserTest.php # tests/Feature/ResetPasswordTest.php # tests/TestCase.php
…-sign-in-page # Conflicts: # resources/js/Layouts/AuthLayout.vue # routes/web.php
…rgotPasswordPage.vue`, enhance form handling and routes.
…into 11-add-sign-in-page
…book login button with API integration, and improve form styling and validation. Add `laravel/socialite` dependency and refactor authentication components.
…pdated form handling for `LoginPage`, `RegisterPage`, and `ForgotPasswordPage`, define shared types, and integrate reusable API client service.
…sage in `RegisterController`.
… `HomePage`, and adjust `Layout.vue` structure.
…, remove unused `notification` messages, and simplify props/emits definitions across components.
…andling and validation across `LoginPage`, `RegisterPage`, and `ForgotPasswordPage`, and update `useApiForm` composable with enhanced error handling and typings.
…consistent typography, update labels, expand InertiaLink usage, enhance notification messages, and update `web.php` routes for URL standardization. Add Prettier for code formatting.
…ponsive behavior in `Layout.vue`.
… with a reusable `PasswordInput` component, enhance form styling, and update `AuthLayout` structure for better usability and consistency.
Member
EwelinaSkrzypacz
left a comment
EwelinaSkrzypacz
left a comment
There was a problem hiding this comment.
On desktop we have a lot of space, but profile looks like mobile view
Can we make smth with it?
-
I'm not sure that in profile we should show user ID; also I will move email to the top (maybe under user name?)
-
Missing browser card title on profile page
-
BTW. please fix typo - instead of "Bądź na bieżaco" it should be "Bądź na bieżąco"
Member
|
As we spoke on daily, profile will be improved in next pr |
…nsistent prop naming and improved readability. Fixed typo in homepage heading text.
dawidrudnik
reviewed
Jul 29, 2025
Co-authored-by: Dawid Rudnik <[email protected]>
dawidrudnik
reviewed
Jul 30, 2025
resources/js/Pages/EventPage.vue
Outdated
| :icon="UsersIcon" | ||
| title="12056 osób weźmie udział" | ||
| class="max-sm:hidden" | ||
| :title="`${event.participants ?? 0} osób weźmie udział`" class="max-sm:hidden" |
Member
There was a problem hiding this comment.
What if event.patricipants return 2. Then message will be 2 osób weżmie udział 🤔
Member
There was a problem hiding this comment.
I'm not a big fan of 0 Weźmie udział. For me, it should be something like Nikt nie bierze udziału. And when the number is greater than 0, I think it would be better to show a message like Liczba uczestników: n
What do you think @EwelinaSkrzypacz 🤔
Co-authored-by: Dawid Rudnik <[email protected]>
…-events # Conflicts: # resources/js/Pages/EventPage.vue
dawidrudnik
reviewed
Jul 30, 2025
Co-authored-by: Dawid Rudnik <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR implements a map of events feature by adding event listing pages, dynamic event detail pages, and map functionality. The changes support viewing events on a map with markers and popups, browsing events in list/card views, and viewing individual event details.
- Restructures routing to support parameterized event pages and new event list page
- Adds comprehensive event type definitions and date formatting utilities
- Refactors authentication and user interaction logic into reusable composables
Reviewed Changes
Copilot reviewed 20 out of 20 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| routes/web.php | Updates routing structure for events and profiles with parameters |
| resources/js/utilities/formatDate.ts | Adds date formatting utilities for Polish locale |
| resources/js/types/events.ts | Defines TypeScript interfaces for event data structures |
| resources/js/composables/*.ts | Creates reusable composables for auth, events, and interactions |
| resources/js/Pages/EventPage.vue | Transforms static event page to dynamic with API data |
| resources/js/Pages/EventList.vue | New event listing page with search and pagination |
| resources/js/Pages/ProfilePage.vue | Enhanced profile page with user events and follow functionality |
| resources/js/Components/*.vue | New components for event cards, popups, and pagination |
| resources/css/app.css | Adds custom styles for map popup styling |
…a computed property `participantsMessage` for cleaner logic and dynamic messaging. Improved formatting of date and time information in event details.
Co-authored-by: Copilot <[email protected]>
EwelinaSkrzypacz
approved these changes
Jul 31, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should close 51-map-of-events