#9 CRUD for Course Materials #21
Conversation
EwelinaSkrzypacz
left a comment
EwelinaSkrzypacz
left a comment
There was a problem hiding this comment.
- Please fix checks - all are failed.
- Add in navigation button to course materials list - now I had to manually write url to the page
- I think that we should first merge pr with course and after that we can make change to this code - I mean that for now I can't add course materials because I can't create course now; I see that we have model
Lessonbut I think we should change this to course - Add validation in create/edit form - for example, when user go to create course material page and fills nothing, just click "Save" I see only frontend validation - please add also backend validation and show message
- Missing empty state;
- Missing title on browser card
-
Please add screenshots to pr.
-
Please include the task number related to this pull request in the description.
| @@ -0,0 +1,258 @@ | |||
|
|
|||
| @@ -0,0 +1,11 @@ | |||
| [90m= [39m[34;4mInterns2024c\Models\CourseMaterial[39;24m {#6442 | |||
There was a problem hiding this comment.
Do we need this file? Why the name of this file look like line of code to get all materials?
| @@ -0,0 +1,12 @@ | |||
| [90m= [39m[34;4mIlluminate\Database\Eloquent\Collection[39;24m {#6273 | |||
| </div> | ||
| </template> | ||
|
|
||
| <script> |
There was a problem hiding this comment.
Please move <script> to the top - like we have for example in Register.vue file
| <button | ||
| @click="editMaterial(material.id)" | ||
| style=" | ||
| margin-top: 15px; |
There was a problem hiding this comment.
Please use tailwindcss to style stuff
| Route::delete("/profile", [ProfileController::class, "destroy"])->name("profile.destroy"); | ||
| }); | ||
|
|
||
| // Debug lessons route |
There was a problem hiding this comment.
Please remove this route - as I understand it's for debugging, so it shouldn't be pushed
There was a problem hiding this comment.
Why permissions are changed?
| }, | ||
| setup(props) { | ||
| console.log('Lessons prop (raw):', props.lessons); |
There was a problem hiding this comment.
Please remove this console.log
Added a navigation button to the Course Materials list for easier access. Previously, the URL had to be manually entered to navigate to the page.
EwelinaSkrzypacz
left a comment
EwelinaSkrzypacz
left a comment
There was a problem hiding this comment.
I'll be happy to review this PR once all checks have passed and my feedback has been implemented.
Implemented CRUD functionality for course materials.
Integrated create, read, update, and delete operations into the system.
Connected CRUD features with the Vue.js and Inertia.js front end.