#8- Crud For Course #19
Conversation
- Created the model for managing course data. - Implemented the to handle CRUD operations for courses. - Added migration file to create table in the database. - Updated routes to include routes for managing courses. - Created to seed initial course data into the database. - Set up view components for displaying course listings and details
…grid layout, styled course cards, and improved button styles with hover effects
There was a problem hiding this comment.
- Please fix checks - all are failed.
- Add in navigation button to course list - now I had to manually write url to the page
- Add validation in create/edit form - for example, when user go to create course page and fills nothing, just click "Save" nothing happens - he should see validation messages under each field like "Title is required"; also we should validate length of fields. Also course title should be unique maybe?
- Missing empty state; also filters don't look good - arrow is on the text, but it should be next to text
- Where is navigation? All pages should have navigation like here.
- On course index page I see that we have filter "Skill" and we have some options
But on create course page I can write anything in skill field - please make some select with skill levels
- Please be consistent with design - create course and update course looks different
Create course page
Edit course page
- Missing title on browser card
- I'm not fan of this solution - we should make custom modals for deleting stuff
-
Course index - If we have filter for date, we should show it somehow
-
I believe that we don't need ziggy
-
Please add screenshots to pr.
-
Please include the task number related to this pull request in the description.
There was a problem hiding this comment.
All files in .idea directory should be ignored (I meas that shouldn't be pushed on branch)
|
|
||
| $query = Course::query(); | ||
|
|
||
|
|
There was a problem hiding this comment.
Please remove unnecessary lines - if you run make fix it should be done automatically
| class CoursePolicy | ||
| { | ||
| /** | ||
| * Determine whether the user can view any models. |
There was a problem hiding this comment.
Do we need comments here?
| <template> | ||
| <div class="max-w-4xl mx-auto mt-10"> | ||
| <h1 class="text-2xl font-bold mb-6 text-center">Create New Course</h1> | ||
| <form @submit.prevent="submit" class="bg-white p-6 rounded-lg shadow-md space-y-4"> |
There was a problem hiding this comment.
Please fix all GitHub warnings
| </div> | ||
| </template> | ||
|
|
||
| <script> |
There was a problem hiding this comment.
Please move <script> to the top - like we have for example in Register.vue file
|
|
||
| <style scoped> | ||
| </style> No newline at end of file |
There was a problem hiding this comment.
Missing empty line at the end ot the file
| <style scoped> | ||
There was a problem hiding this comment.
If we don't have scoped style, we don't need this tag - please remove
| @@ -0,0 +1,24 @@ | |||
| import { createRouter, createWebHistory, RouteRecordRaw } from 'vue-router'; | |||
|
|
|||
| // Sayfa bileşenlerini import et | |||
There was a problem hiding this comment.
I don't understand this comment - is really necessary?
|
|
||
|
|
||
| Route::middleware(["auth"])->group(function (): void { | ||
| // course crud route |
There was a problem hiding this comment.
Please remove all unnecessary comments
There was a problem hiding this comment.
You shouldn't change permissions to these files 👀
…uced button sizes, and centered the 'Apply' button. Increased navbar font size and weight.
…ced button sizes, and centered the 'Apply' button. Increased navbar font size and weight.
-Implemented course creation, editing, and deletion features with confirmation