#24 - Caspary provider #30
Conversation
It should close #24
| @@ -0,0 +1,24 @@ | |||
| server { | |||
There was a problem hiding this comment.
This file is not needed I suppose
cmd/run.php
Outdated
|
|
||
| match ($breweryOption) { | ||
| Breweries::SEARCH => $climate->table($breweries->getBreweries($breweriesCollection)->toArray()), | ||
| Breweries::SEARCH => $climate->table($breweries->getBreweries($breweriesFactory)->toArray()), |
There was a problem hiding this comment.
due to working on old version of code, changed in commits
| $html = file_get_contents($url); | ||
| $crawler = new Crawler($html); | ||
|
|
||
| $this->walker = $crawler->filterXPath("//*[@id='referenzmenu']"); |
There was a problem hiding this comment.
Why $this->walker? There is no property named walker
There was a problem hiding this comment.
It is a result of few mistakes that I did due to rush
Changed as $section
There was a problem hiding this comment.
I don't see this change in changed files. Probably changes have not been pushed?
| "ext-readline": "*", | ||
| "guzzlehttp/guzzle": "^7.4", | ||
| "illuminate/collections": "^9.19", | ||
| "illuminate/support": "^4.2", |
There was a problem hiding this comment.
Why you need this package? You can use illuminate/collections instead.
To remove package use composer remove <package name>
|
@AleksandraKozubal, are you going to respond to the code review? If not, I will archive this project. Otherwise, I can wait until you'd finish that PR. |
|
Yes I will asap |
Ok, ok. I will remove your access after this PR will be merged. |
Co-authored-by: Marcin Tracz <[email protected]>
It should close #24