Port andor to ophyd-async #679
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DiamondJoseph
force-pushed
the
port-andor
branch
from
ff2448c to
f9124dd
Compare
DiamondJoseph
force-pushed
the
port-andor
branch
from
f9124dd to
ea285a7
Compare
|
I have not touched the ophyd-async StandardDetectors in a while, so I'd appreciate some careful eyes. I'm going to try and connect it to p99 this week. |
|
Yep, I just wanted the responsibility to update this here rather than in dodal :D |
|
I've made a new PR that slightly modifies these to work with the new base classes. Tests are all passing, but would be good to test with the real thing if we can. |
I can try fire it up, I guess we just want to take a few imagie and make sure it all still work? |
evalott100
reviewed
Jan 9, 2025
|
Closing in favour of #724. @evalott100 please could you review that one instead? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves work by @Relm-Arrowny to ophyd-async from DiamondLightSource/dodal#807
Adds Andor2 AreaDetector implementation in standard ophyd-async form: ophyd-async aims to unify all StandardDetector implementations prior to 1.0, so moving implementation here to ensure requirements remain met and to ensure device updates smoothly.