Skip to content

Add unchecked functions #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 23 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ enum OneEnum {
}
```

where the inner item can be retrieved with the `as_*()`/`as_*_mut()` or with the `into_*()` functions:
where the inner item can be retrieved with the `as_*()`/`as_*_mut()`, `into_*()` or with the `*unchecked` functions:

```rust
let one = OneEnum::One(1);
Expand All @@ -28,9 +28,15 @@ let mut one = OneEnum::One(2);
assert_eq!(*one.as_one().unwrap(), 1);
assert_eq!(*one.as_one_mut().unwrap(), 1);
assert_eq!(one.into_one().unwrap(), 1);

unsafe {
assert_eq!(*one.as_one_unchecked(), 1);
assert_eq!(*one.as_one_mut_unchecked(), 1);
assert_eq!(one.into_one_unchecked(), 1);
}
```

where the result is either a reference for inner items or a tuple containing the inner items.
where the result is either a reference for inner items or a tuple containing the inner items. The `*unchecked` functions are unsafe and return either a reference or a tuple containing the inner items.

## Unit case

Expand Down Expand Up @@ -74,6 +80,13 @@ let mut many = ManyVariants::Three(true, 1, 2);
assert_eq!(many.as_three().unwrap(), (&true, &1_u32, &2_i64));
assert_eq!(many.as_three_mut().unwrap(), (&mut true, &mut 1_u32, &mut 2_i64));
assert_eq!(many.into_three().unwrap(), (true, 1_u32, 2_i64));

unsafe {
assert_eq!(many.as_three_unchecked(), (&true, &1_u32, &2_i64));
assert_eq!(many.as_three_mut_unchecked(), (&mut true, &mut 1_u32, &mut 2_i64));
assert_eq!(many.into_three_unchecked(), (true, 1_u32, 2_i64));
}

```

## Multiple, named field case
Expand All @@ -99,4 +112,12 @@ let mut many = ManyVariants::Three{ one: true, two: 1, three: 2 };
assert_eq!(many.as_three().unwrap(), (&true, &1_u32, &2_i64));
assert_eq!(many.as_three_mut().unwrap(), (&mut true, &mut 1_u32, &mut 2_i64));
assert_eq!(many.into_three().unwrap(), (true, 1_u32, 2_i64));

unsafe {
assert_eq!(many.as_three_unchecked(), (&true, &1_u32, &2_i64));
assert_eq!(many.as_three_mut_unchecked(), (&mut true, &mut 1_u32, &mut 2_i64));
assert_eq!(many.into_three_unchecked(), (true, 1_u32, 2_i64));
}


```
99 changes: 99 additions & 0 deletions src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,9 @@ fn unnamed_fields_return(
(function_name_mut_ref, doc_mut_ref): (&Ident, &str),
(function_name_ref, doc_ref): (&Ident, &str),
(function_name_val, doc_val): (&Ident, &str),
(function_name_val_unchecked, doc_val_unchecked): (&Ident, &str),
(function_name_ref_unchecked, doc_ref_unchecked): (&Ident, &str),
(function_name_mut_ref_unchecked, doc_mut_ref_unchecked): (&Ident, &str),
fields: &syn::FieldsUnnamed,
) -> TokenStream {
let (returns_mut_ref, returns_ref, returns_val, matches) = match fields.unnamed.len() {
Expand Down Expand Up @@ -206,6 +209,33 @@ fn unnamed_fields_return(
_ => ::core::result::Result::Err(self)
}
}

#[doc = #doc_val_unchecked ]
#[inline]
pub unsafe fn #function_name_val_unchecked(self) -> #returns_val {
match self {
Self::#variant_name(#matches) => (#matches),
_ => std::hint::unreachable_unchecked(),
}
}

#[doc = #doc_ref_unchecked ]
#[inline]
pub unsafe fn #function_name_ref_unchecked(&self) -> #returns_ref {
match self {
Self::#variant_name(#matches) => (#matches),
_ => std::hint::unreachable_unchecked(),
}
}

#[doc = #doc_mut_ref_unchecked ]
#[inline]
pub unsafe fn #function_name_mut_ref_unchecked(&mut self) -> #returns_mut_ref {
match self {
Self::#variant_name(#matches) => (#matches),
_ => std::hint::unreachable_unchecked(),
}
}
)
}

Expand All @@ -216,6 +246,9 @@ fn named_fields_return(
(function_name_mut_ref, doc_mut_ref): (&Ident, &str),
(function_name_ref, doc_ref): (&Ident, &str),
(function_name_val, doc_val): (&Ident, &str),
(function_name_val_unchecked, doc_val_unchecked): (&Ident, &str),
(function_name_ref_unchecked, doc_ref_unchecked): (&Ident, &str),
(function_name_mut_ref_unchecked, doc_mut_ref_unchecked): (&Ident, &str),
fields: &syn::FieldsNamed,
) -> TokenStream {
let (returns_mut_ref, returns_ref, returns_val, matches) = match fields.named.len() {
Expand Down Expand Up @@ -297,6 +330,33 @@ fn named_fields_return(
_ => ::core::result::Result::Err(self)
}
}

#[doc = #doc_val_unchecked ]
#[inline]
pub unsafe fn #function_name_val_unchecked(self) -> #returns_val {
match self {
Self::#variant_name{ #matches } => (#matches),
_ => std::hint::unreachable_unchecked(),
}
}

#[doc = #doc_ref_unchecked ]
#[inline]
pub unsafe fn #function_name_ref_unchecked(&self) -> #returns_ref {
match self {
Self::#variant_name{ #matches } => (#matches),
_ => std::hint::unreachable_unchecked(),
}
}

#[doc = #doc_mut_ref_unchecked ]
#[inline]
pub unsafe fn #function_name_mut_ref_unchecked(&mut self) -> #returns_mut_ref {
match self {
Self::#variant_name{ #matches } => (#matches),
_ => std::hint::unreachable_unchecked(),
}
}
)
}

Expand Down Expand Up @@ -352,6 +412,39 @@ fn impl_all_as_fns(ast: &DeriveInput) -> TokenStream {
name, variant_name,
);

let function_name_val_unchecked = Ident::new(
&format!("into_{}_unchecked", variant_name).to_snake_case(),
Span::call_site(),
);
let doc_val_unchecked = format!(
r#"Unchecked return of the inner fields of `{}::{}`.
# Safety
Results in undefined behavior when it is the incorrect variant."#,
name, variant_name
);

let function_name_ref_unchecked = Ident::new(
&format!("as_{}_unchecked", variant_name).to_snake_case(),
Span::call_site(),
);
let doc_ref_unchecked = format!(
r#"Unchecked reference of the inner fields of `{}::{}`.
# Safety
Results in undefined behavior when it is the incorrect variant."#,
name, variant_name
);

let function_name_mut_ref_unchecked = Ident::new(
&format!("as_{}_mut_unchecked", variant_name).to_snake_case(),
Span::call_site(),
);
let doc_mut_ref_unchecked = format!(
r#"Unchecked mutable reference of the inner fields of `{}::{}`.
# Safety
Results in undefined behavior when it is the incorrect variant."#,
name, variant_name
);

let tokens = match &variant_data.fields {
syn::Fields::Unit => unit_fields_return(variant_name, &function_name_is, &doc_is),
syn::Fields::Unnamed(unnamed) => unnamed_fields_return(
Expand All @@ -360,6 +453,9 @@ fn impl_all_as_fns(ast: &DeriveInput) -> TokenStream {
(&function_name_mut_ref, &doc_mut_ref),
(&function_name_ref, &doc_ref),
(&function_name_val, &doc_val),
(&function_name_val_unchecked, &doc_val_unchecked),
(&function_name_ref_unchecked, &doc_ref_unchecked),
(&function_name_mut_ref_unchecked, &doc_mut_ref_unchecked),
unnamed,
),
syn::Fields::Named(named) => named_fields_return(
Expand All @@ -368,6 +464,9 @@ fn impl_all_as_fns(ast: &DeriveInput) -> TokenStream {
(&function_name_mut_ref, &doc_mut_ref),
(&function_name_ref, &doc_ref),
(&function_name_val, &doc_val),
(&function_name_val_unchecked, &doc_val_unchecked),
(&function_name_ref_unchecked, &doc_ref_unchecked),
(&function_name_mut_ref_unchecked, &doc_mut_ref_unchecked),
named,
),
};
Expand Down
18 changes: 15 additions & 3 deletions tests/basic.rs
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ fn test_empty() {
assert!(empty.is_none());
}

#[derive(Debug, EnumAsInner)]
#[derive(Debug, EnumAsInner, Clone, Copy)]
enum EmptyParendsTest {
Empty(),
}
Expand All @@ -59,7 +59,7 @@ fn test_empty_parends() {
.expect("should have been something and a unit");
}

#[derive(Debug, EnumAsInner)]
#[derive(Debug, EnumAsInner, Clone, Copy)]
enum OneTest {
One(u32),
}
Expand All @@ -72,9 +72,15 @@ fn test_one() {
assert_eq!(*empty.as_one().unwrap(), 1);
assert_eq!(*empty.as_one_mut().unwrap(), 1);
assert_eq!(empty.into_one().unwrap(), 1);

unsafe {
assert_eq!(empty.into_one_unchecked(), 1);
assert_eq!(*empty.as_one_unchecked(), 1);
assert_eq!(*empty.as_one_mut_unchecked(), 1);
}
}

#[derive(Debug, EnumAsInner)]
#[derive(Debug, EnumAsInner, Clone, Copy)]
enum MultiTest {
Multi(u32, u32),
}
Expand All @@ -87,4 +93,10 @@ fn test_multi() {
assert_eq!(multi.as_multi().unwrap(), (&1_u32, &1_u32));
assert_eq!(multi.as_multi_mut().unwrap(), (&mut 1_u32, &mut 1_u32));
assert_eq!(multi.into_multi().unwrap(), (1_u32, 1_u32));

unsafe {
assert_eq!(multi.as_multi_unchecked(), (&1_u32, &1_u32));
assert_eq!(multi.as_multi_mut_unchecked(), (&mut 1_u32, &mut 1_u32));
assert_eq!(multi.into_multi_unchecked(), (1_u32, 1_u32));
}
}
5 changes: 5 additions & 0 deletions tests/generics.rs
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,11 @@ fn with_generics() {
assert_eq!(with_generics.into_a().unwrap(), 100);
assert_eq!(*with_generics.as_a().unwrap(), 100);
assert_eq!(*with_generics.as_a_mut().unwrap(), 100);
unsafe {
assert_eq!(with_generics.into_a_unchecked(), 100);
assert_eq!(*with_generics.as_a_unchecked(), 100);
assert_eq!(*with_generics.as_a_mut_unchecked(), 100);
}

assert!(with_generics.into_b().is_err());
assert!(with_generics.as_b().is_none());
Expand Down
22 changes: 21 additions & 1 deletion tests/named.rs
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ pub mod name_collisions {
#[allow(unused_imports)]
use name_collisions::*;

#[derive(Debug, EnumAsInner)]
#[derive(Debug, EnumAsInner, Copy, Clone)]
enum ManyVariants {
One { one: u32 },
Two { one: u32, two: i32 },
Expand All @@ -51,6 +51,11 @@ fn test_one_named() {

assert_eq!(*many.as_one().unwrap(), 1_u32);
assert_eq!(*many.as_one_mut().unwrap(), 1_u32);

unsafe {
assert_eq!(*many.as_one_unchecked(), 1_u32);
assert_eq!(*many.as_one_mut_unchecked(), 1_u32);
}
}

#[test]
Expand All @@ -70,6 +75,12 @@ fn test_two_named() {
assert_eq!(many.as_two().unwrap(), (&1_u32, &2_i32));
assert_eq!(many.as_two_mut().unwrap(), (&mut 1_u32, &mut 2_i32));
assert_eq!(many.into_two().unwrap(), (1_u32, 2_i32));

unsafe {
assert_eq!(many.as_two_unchecked(), (&1_u32, &2_i32));
assert_eq!(many.as_two_mut_unchecked(), (&mut 1_u32, &mut 2_i32));
assert_eq!(many.into_two_unchecked(), (1_u32, 2_i32));
}
}

#[test]
Expand All @@ -96,4 +107,13 @@ fn test_three_named() {
(&mut true, &mut 1_u32, &mut 2_i64)
);
assert_eq!(many.into_three().unwrap(), (true, 1_u32, 2_i64));

unsafe {
assert_eq!(many.as_three_unchecked(), (&true, &1_u32, &2_i64));
assert_eq!(
many.as_three_mut_unchecked(),
(&mut true, &mut 1_u32, &mut 2_i64)
);
assert_eq!(many.into_three_unchecked(), (true, 1_u32, 2_i64));
}
}
12 changes: 11 additions & 1 deletion tests/snake_case.rs
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ pub mod name_collisions {
#[allow(unused_imports)]
use name_collisions::*;

#[derive(Debug, EnumAsInner)]
#[derive(Debug, EnumAsInner, Copy, Clone)]
#[allow(non_camel_case_types)]
#[allow(clippy::upper_case_acronyms)]
enum MixedCaseVariants {
Expand Down Expand Up @@ -54,6 +54,11 @@ fn test_rust_unnamed() {

assert_eq!(*mixed.as_rust_is_cool_though().unwrap(), 42);
assert_eq!(mixed.into_rust_is_cool_though().unwrap(), 42);

unsafe {
assert_eq!(*mixed.as_rust_is_cool_though_unchecked(), 42);
assert_eq!(mixed.into_rust_is_cool_though_unchecked(), 42);
}
}

#[test]
Expand All @@ -66,4 +71,9 @@ fn test_ymca_named() {

assert_eq!(*mixed.as_ymca().unwrap(), (-32_768));
assert_eq!(mixed.into_ymca().unwrap(), (-32_768));

unsafe {
assert_eq!(*mixed.as_ymca_unchecked(), (-32_768));
assert_eq!(mixed.into_ymca_unchecked(), (-32_768));
}
}
23 changes: 22 additions & 1 deletion tests/unnamed.rs
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ pub mod name_collisions {
#[allow(unused_imports)]
use name_collisions::*;

#[derive(Debug, EnumAsInner)]
#[derive(Debug, EnumAsInner, Clone, Copy)]
enum ManyVariants {
One(u32),
Two(u32, i32),
Expand All @@ -52,6 +52,12 @@ fn test_one_unnamed() {
assert_eq!(*many.as_one().unwrap(), 1_u32);
assert_eq!(*many.as_one_mut().unwrap(), 1_u32);
assert_eq!(many.into_one().unwrap(), 1_u32);

unsafe {
assert_eq!(*many.as_one_unchecked(), 1_u32);
assert_eq!(*many.as_one_mut_unchecked(), 1_u32);
assert_eq!(many.into_one_unchecked(), 1_u32);
}
}

#[test]
Expand All @@ -73,6 +79,12 @@ fn test_two_unnamed() {
assert_eq!(many.as_two().unwrap(), (&1_u32, &2_i32));
assert_eq!(many.as_two_mut().unwrap(), (&mut 1_u32, &mut 2_i32));
assert_eq!(many.into_two().unwrap(), (1_u32, 2_i32));

unsafe {
assert_eq!(many.as_two_unchecked(), (&1_u32, &2_i32));
assert_eq!(many.as_two_mut_unchecked(), (&mut 1_u32, &mut 2_i32));
assert_eq!(many.into_two_unchecked(), (1_u32, 2_i32));
}
}

#[test]
Expand All @@ -97,4 +109,13 @@ fn test_three_unnamed() {
(&mut true, &mut 1_u32, &mut 2_i64)
);
assert_eq!(many.into_three().unwrap(), (true, 1_u32, 2_i64));

unsafe {
assert_eq!(many.as_three_unchecked(), (&true, &1_u32, &2_i64));
assert_eq!(
many.as_three_mut_unchecked(),
(&mut true, &mut 1_u32, &mut 2_i64)
);
assert_eq!(many.into_three_unchecked(), (true, 1_u32, 2_i64));
}
}