-
Notifications
You must be signed in to change notification settings - Fork 8
Add metrics for mdisk, mb, io, ms #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Build failed, need to update the test maybe? |
Cool! You should definitely convert these to seconds and bytes though, as per https://prometheus.io/docs/practices/naming/#base-units. It is much easier if all the metrics are in base SI units. |
I think you need to rebase this branch on top of the new master, right now you have conflicts with your previous PR after it got merged through a rebase. |
Alright, I will look into it next week or so :) Thanks for the link! |
Yeah, I had a feeling thats needed when my last PR included old commits. Will look into it next week as well. |
Wonder if "* 1024 * 1024" should be added to the new mb metrics?
IBM docs aint the best nor easiest to understand :D