Skip to content

Add metrics for mdisk, mb, io, ms #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

trappiz
Copy link
Contributor

@trappiz trappiz commented Mar 29, 2021

Wonder if "* 1024 * 1024" should be added to the new mb metrics?
IBM docs aint the best nor easiest to understand :D

@trappiz
Copy link
Contributor Author

trappiz commented Mar 29, 2021

Build failed, need to update the test maybe?
Also, replace all mdisk in this PR with vdisk instead. Mdisk is backend and not the info from the gui of storwize itself.

@bluecmd
Copy link
Owner

bluecmd commented Mar 29, 2021

Cool!

You should definitely convert these to seconds and bytes though, as per https://prometheus.io/docs/practices/naming/#base-units. It is much easier if all the metrics are in base SI units.

@bluecmd
Copy link
Owner

bluecmd commented Mar 29, 2021

I think you need to rebase this branch on top of the new master, right now you have conflicts with your previous PR after it got merged through a rebase.

@trappiz
Copy link
Contributor Author

trappiz commented Apr 2, 2021

Cool!

You should definitely convert these to seconds and bytes though, as per https://prometheus.io/docs/practices/naming/#base-units. It is much easier if all the metrics are in base SI units.

Alright, I will look into it next week or so :) Thanks for the link!

@trappiz
Copy link
Contributor Author

trappiz commented Apr 2, 2021

I think you need to rebase this branch on top of the new master, right now you have conflicts with your previous PR after it got merged through a rebase.

Yeah, I had a feeling thats needed when my last PR included old commits. Will look into it next week as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants