HX Evolution...? by JadeOfMaar · Pull Request #81 · blowfishpro/B9-Aerospace

JadeOfMaar · 2018-10-16T21:03:42Z

Changelog:

* Instancing of the HX HPD engine (there are now 3 of it) to meet advanced/various propulsion needs.
* Rebalanced original HPD engine to be more viable for use in very large HX ships or HX ships that simply want to go very, very far.
* Added B9 HX tank types for LiquidFuel and for new engine modes.
* Added/changed plumes for all engine modes.
* Instancing of RCS thrusters (LFO versions).
* Nerfed RTG in HX URC reactor.
* HX URC reactor becomes full-featured reactor compatible with Near Future Electrical and Wild Blue Industries (WBI) DSEV.
* Added support for WBI Play Mode to HX. Switch between Community Resource Pack requirements and B9 fuel options; and Classic Stock resource requirements and use Wild Blue OmniStorage.
* Moved most existing patch files in accordance with Play Mode.	
* Raised heat tolerances of HX parts from 2000K to 2700K.
* Adjusted CTT locations. Most parts will now appear in Orbital Megastructures. RCS and engines will appear in Very Heavy Rocketry and Gigantic Rocketry.

* Rebalanced HPD engine * Instanced engine for other propellant needs * WBI Play Mode support * Moved patch files regading WBI support * New plumes for engines * Rebalanced URC reactor (nerfed RTG, made NF Electical compatible) * Raised heat tolerances to 2700K

types for: karborundum and water; lqdhydrogen

* adjust tech nodes * clone LFO version

* adjust tech nodes on all parts * update OmniStorage and subtype deletion * retune some engines' EC consumption

blowfishpro · 2018-10-16T21:06:44Z

GameData/B9_Aerospace_HX/B9_Aerospace_HX-Tank_Types.cfg

 	}
+}
+
+B9_TANK_TYPE


Should have :NEEDS for when the resources don't exist

I'll get on that.

blowfishpro · 2018-10-16T21:07:29Z

GameData/B9_Aerospace_HX/Parts/Structure_HX/model_hpd1.cfg

+        secondaryEngineID = SupraNuclear
    }
-
+	


fancy new engine mode names to distinguish them and their characteristics from the typical ClosedCycle and Nuclear.

SupraLox: Beyond LFO convention

SupraNuclear: Beyond NTR convention

I was talking about the tab added to an empty line

blowfishpro · 2018-10-16T21:08:04Z

GameData/B9_Aerospace_HX/Parts/Structure_HX/model_hpd1.cfg

        useEngineResponseTime = True
        engineAccelerationSpeed = 1.60
        engineDecelerationSpeed = 2
+		exhaustDamageMultiplier = 2400


There seem to be some inconsistency between tabs and spaces here...

I wasn't aware of the indentations being loads of spaces. I'll fix all that as well.

blowfishpro · 2018-10-16T21:08:35Z

GameData/B9_Aerospace_HX/Parts/Structure_HX/model_hpd1.cfg

SupraNuclear is an NTR/plasma/hybrid engine mode. afaik it tends to easily flameout in high atmosphere pressure. I didn't think to buff it with respect to this engine's size. Also, I wasn't aware the indentation here is a load of spaces.

Tab added to empty line

blowfishpro · 2018-10-16T21:10:29Z

GameData/B9_Aerospace_HX/Patches/CRP/B9_Aerospace_HX-Engine_Instance.cfg

+		@heatProduction = 500
+		@maxThrust = 24000
+		!PROPELLANT,* {}
+		PROPELLANT:NEEDS[CommunityResourcePack]


Won't this end up with no propellants in CRP is not installed?

I've had many issues where KSP hangs because an engine failed to compile because resource definitions for its propellants are missing. Here, KSP will not hang but the engine will be harmless to the startup process (although, by consequence, also useless, to reduce the incoming hard dependence on CRP. Perhaps I should make it hide from part selection in this case?)

I think that would be a better option. Could even be a :NEEDS

Having the engine's even loading in depend on NEEDS, I decided against that as it could break ships in-flight if for whatever reason someone uninstalls CRP. The likelihood of this is actually quite low I think but it seemed a very odd choice.

blowfishpro · 2018-10-16T21:11:59Z

GameData/B9_Aerospace_HX/Patches/CRP/B9_Aerospace_HX-Engine_Instance.cfg

+				speed = 1.0 1.0
+			}
+		}
+		// running_torch


Any reason this is all commented out?

It's a nice config, for one of the sets of plumes that I decided afterward that I wouldn't use. In case I have to add another propellant combo and another engine clone I can de-comment and move this.

blowfishpro · 2018-10-16T21:12:20Z

GameData/B9_Aerospace_HX/Patches/CRP/B9_Aerospace_HX-Engine_Instance.cfg

+		@heatProduction = 200
+		@maxThrust = 4000
+		!PROPELLANT,* {}
+		PROPELLANT:NEEDS[CommunityResourcePack]


Same as above, won't this end up with no propellants?

To reduce the incoming hard dependency on CRP I've opted to make the engine useless if CRP is not installed. This is opposed to possibly seeing KSP hang when propellant resource definitions are missing.

blowfishpro · 2018-10-16T21:15:18Z

GameData/B9_Aerospace_HX/Patches/Classic/B9_Aerospace_HX-Reactor-Compat.txt

@@ -0,0 +1,153 @@
+@PART[B9_Structure_HX1_G]:NEEDS[!DSEV]


I think this needs some more needs

Nah. It doesn't need more needs. When the WBI play mode is switched to Classic Stock and this becomes an active .cfg, this will be the default behavior of the reactor. Near Future Electrical, if present, should not interfere with it, and I can't see KSPI interfering with it (yet).

Ah, that weird stuff with WBI renaming files?

Yes, that. 😄

blowfishpro · 2018-10-16T21:17:03Z

GameData/B9_Aerospace_HX/README.md

@@ -0,0 +1,499 @@
+# Installation


The readme and changelog are copied as part of the build so no need to add them here.

ok? ...These files simply appeared as part of the fork and I simply edited the changelog. Should I PM you the changelog contents then?

I was maintaining a single changelog for the time being. It might eventually be better to split them out, but I don't think just copying the files is sufficient

JadeOfMaar added 6 commits October 12, 2018 01:55

B9 HX bulk changes

b9ec5c3

* Rebalanced HPD engine * Instanced engine for other propellant needs * WBI Play Mode support * Moved patch files regading WBI support * New plumes for engines * Rebalanced URC reactor (nerfed RTG, made NF Electical compatible) * Raised heat tolerances to 2700K

LiquidFuel tank type for all HX parts

5a6bcf3

add tank types

6120de9

types for: karborundum and water; lqdhydrogen

changelog

7efe6ea

RCS update

719aaf3

* adjust tech nodes * clone LFO version

updates & changelog

81df0fa

* adjust tech nodes on all parts * update OmniStorage and subtype deletion * retune some engines' EC consumption

blowfishpro reviewed Oct 16, 2018

View reviewed changes

JadeOfMaar added 3 commits October 16, 2018 21:26

spaces to tabs, and all needed NEEDS

93b57f2

more spaces to tabs, and NEEDS

56526fe

hide engine clones if no CRP

fcce3bf

Conversation

JadeOfMaar commented Oct 16, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants