Skip to content

Fix promise mem types #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gabmontes merged 3 commits into from
Jun 18, 2025
Merged

Fix promise mem types #11

gabmontes merged 3 commits into from
Jun 18, 2025

Conversation

@gabmontes
Copy link
Member

@gabmontes gabmontes commented Jun 17, 2025

The property resolver in promise-mem is optional! This silly bug was causing TS errors to show up.

Process checklist

  • Manual tests passed or not applicable.
  • Automated tests added or not applicable.
  • Documentation updated or not required.

Metrics

Actual effort: 0.5h

@gabmontes gabmontes self-assigned this Jun 17, 2025
@gabmontes gabmontes marked this pull request as ready for review June 17, 2025 21:55
@gabmontes gabmontes enabled auto-merge June 17, 2025 21:55
gndelia
gndelia reviewed Jun 17, 2025
View reviewed changes
Copy link
Contributor

@gndelia gndelia left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't the root's lockfile be updated due to the version update? It seems to me that a npm i was missing after (manually?) updating the version in the package.json 🤔

@gabmontes
Copy link
Member Author

gabmontes commented Jun 17, 2025

@gndelia I don't think that was needed but I just updated the lockfile anyway.

@gabmontes gabmontes requested a review from gndelia June 17, 2025 23:59
@gndelia
Copy link
Contributor

gndelia commented Jun 18, 2025

@gndelia I don't think that was needed but I just updated the lockfile anyway.

true, but the next time someone run a npm i they will see changes appear in the lockfile, so better commit them now 😄

@gabmontes gabmontes merged commit 10a8383 into master Jun 18, 2025
5 of 6 checks passed
@gabmontes gabmontes deleted the fix-promise-mem-types branch June 18, 2025 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gndelia gndelia gndelia approved these changes

@maxivarela maxivarela maxivarela approved these changes

@leanazulyoro leanazulyoro Awaiting requested review from leanazulyoro

@mbonfoster mbonfoster Awaiting requested review from mbonfoster

Assignees

@gabmontes gabmontes

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@gabmontes @gndelia @maxivarela