Minor improvements Part 2 on eth-rpc-cache #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request makes several minor improvements to eth-rpc-cache, including simplifying the cloning logic, removing an unused debug dependency, updating the README with a new bundlephobia badge, and moving configuration files to their conventional locations.
- Removed the custom clone function in favor of native structuredClone.
- Removed the debug dependency and associated logging.
- Updated the README badge and added a new npm-publish workflow.
Reviewed Changes
Copilot reviewed 5 out of 14 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/eth-rpc-cache/src/utils/clone.ts | Removed the custom JSON-based clone utility in favor of structuredClone. |
| packages/eth-rpc-cache/src/rpc.ts | Removed debug logging and replaced the clone function with structuredClone. |
| packages/eth-rpc-cache/README.md | Added the bundlephobia badge alongside the existing NPM version badge. |
| .github/workflows/npm-publish.yml | Added a new npm-publish workflow using hemilabs/actions. |
Files not reviewed (9)
- .commitlintrc.json: Language not supported
- .github/actions/setup-env/action.yml: Language not supported
- .husky/commit-msg: Language not supported
- .husky/pre-commit: Language not supported
- .husky/pre-push: Language not supported
- .lintstagedrc.json: Language not supported
- .prettierrc.json: Language not supported
- package.json: Language not supported
- packages/eth-rpc-cache/package.json: Language not supported
gabmontes
requested changes
Apr 29, 2025
gndelia
requested review from
gabmontes,
leanazulyoro,
maxivarela and
mbonfoster
gabmontes
approved these changes
Apr 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR applies a few minor improvements on the
eth-rpc-cache. It's easier to review by commitcloneutility, so structuredClone is used insteaddebugdependency as it was only used in one place for one particular log. Not really needed.package.jsonso it matches the convention we've generally been usingnpm-publishaction (Here Gabriel you should check thatNPM_TOKENis available)eth-rpc-cache