first commit#208
Open
DavidBenavidez123 wants to merge 2 commits into
Open
Conversation
| //reading from the bitwise right shift will give you the number of operands: | ||
| unsigned char operandA = 0; | ||
| unsigned char operandB = 0; | ||
| unsigned int numOp = IR >> 6; |
There was a problem hiding this comment.
Awesome job with this! Now you need to use it.
| running = 0; | ||
| break; | ||
| default: | ||
| printf("Error"); |
There was a problem hiding this comment.
You can make this error more verbose with the program counter and instruction code for better debugging.
| cpu->reg[7]--; | ||
| cpu->ram[cpu->reg[7]] = val; | ||
| } | ||
| unsigned char cpu_pop(struct cpu *cpu) |
There was a problem hiding this comment.
Now you need to add PUSH and POP instructions to your switch statement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.