Evan Carlstrom - Computer Architecture#204
Open
ecarlstrom wants to merge 18 commits into
Open
Conversation
codejoncode
reviewed
Mar 4, 2019
codejoncode
left a comment
codejoncode
left a comment
There was a problem hiding this comment.
It wasn't needed today but maybe needed down the road add a flag to your cpu struct unsigned char FL;
…te both being within cpu_load(), placed them outside where they are supposed to be. Program now outputs normally.
…change a couple other files to accommodate command line arguments and then check to see if files are handled correctly.
codejoncode
reviewed
Mar 5, 2019
codejoncode
left a comment
codejoncode
left a comment
There was a problem hiding this comment.
Evan looks good only one issue for your ls8.c main function let's add a condition in because now your program depend on a file name as an argument.
if (argc != 2) {
fprintf(stderr, "usage: ls8 file.ls8\n");
return 1;
}
codejoncode
reviewed
Mar 7, 2019
codejoncode
left a comment
codejoncode
left a comment
There was a problem hiding this comment.
To stay consistent maybe a good idea to have your PUSH and POP in the cpu.h file
#define PUSH 0b01000101
#define POP 0b01000110
…dded to the cpu struct.
… calls as they're now handled by calls
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.