Kevin Sooter - Computer-Architecture

[kevin-sooter]

No description provided.

[codejoncode]

It wasn't needed today but maybe needed down the road add a flag to your cpu struct unsigned char FL;

[codejoncode]

Kevin you should be updating cpu->ram we don't need data anymore.

[codejoncode]

Looks Good Kevin getting MUL to work nicely.

[codejoncode]

// True if this instruction might set the PC
`int instruction_set_pc = (IR >> 4) & 1;`
//Above^^^^^^^^^^^should before the while loop

// increase PC after the switch

if (!instruction_set_pc) {
cpu->PC += ((IR >> 6) & 0x3) + 1;
}

//this is because the first 2 bits to the left of the instruction will tell you how many operands

this will prevent you from having to use two switch statements.

[codejoncode]

ret = strtoul(c, &endptr, 2); inside of cpu_load lets make ret = strtol(line, &endchar, 2);

in cpu_load function

[codejoncode]

char c[100] lets make a little bigger char c[1024]

also change your while loop while (fgets(line, sizeof line, fp) != NULL)

in cpu_load function

[codejoncode]

// Open the source file in Cpu_load function

FILE *ptr; 
  if ((ptr = fopen(argv, "r")) == NULL) {
    fprintf(stderr, "Cannot open file %s\n", filename);
    exit(2);
  }

This condidtion should help us spot errors if there are any.

[codejoncode]

FILE *fptr;
  if ((fptr = fopen(argv[1], "r")) == NULL)
  {
    printf("No such file.\n");
    exit(1);
  }
  fclose(fptr);

No need for this to be in the main loop this should be in your cpu_load function.