Rebased to 432-SNAPSHOT and fixed the issue by reviewer. #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds SESSION_AUTHORIZATION to ClientCapabilities, so that the client side support for this feature can be identified using the headers sent to Trino.
This upgrades Delta Lake version to 3.0.0.
Refactor TestRetryingConnectionFactory and TestLazyConnectionFactory to use Dependency Injection Motivation behind this change is to be able to later add dependent objects to tested class without a need for major changes in the test class itself.
Extend the logic to specially treat metadata queries and not allocate any memory for those, so they are scheduled immediatelly, to cover all schematas from system catalog (previously only jdbc schama was covered).
This bit of code is making the assumption that it's safe to remove the Sort because there are no exchanges yet. However, it's forgetting the fact that the data needs to be sorted, so later when the exchange is added this expectation is broken.
Implements column-wise hash calculations in FlatHashCompiler and changes FlatGroupByHash to use it to implement a batched approach to first computing a range of position hashes and then attempting to insert those positions using the hashes that were precomputed. By calculating position hashes in a columnar tarversal path, we can avoid repeated expensive bounds checking and allow the JIT to unroll loops into much more efficient forms. Additionally, when attempting to insert the positions into the FlatGroupByHash after precomputing the hash code we can start loading the relevant portition of the hash table into memory sooner since we aren't intermixing computing the hash with the memory accesses.
Once the table is created, attempt to get the stats a few times while waiting for PostgreSQL to analyze the table and declare success as soon as the stats are available. Previously, every iteration of the test had a race condition between creating the table and checking for stats, which led to many of the iterations to fail.
The arguments are not valid for the test.
Depending on which order the test runs in, it may pick up the schema mappings from other tests and fail. The mapping needs to be initialized appropriately.
Fully tested with Trino 406. Untested with 410.
Adding --add-opens to enable support for Apache Arrow via shared memory buffers.
TODO: testDataMappingSmokeTest: time and timestamp testSetColumnTypes: time and timestamp
This reverts commit 82f9eb3f3811e8d90a482f5359e98e7c729afa17.
Fully tested with Trino 406. Untested with 410.
…with Snowflake server. Disabled the testsetColumnTypes testing.
yuuteng
force-pushed
the
bloomberg-snowflake
branch
from
5520b5f to
b10a001
Compare
yuuteng
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebased to 432-SNAPSHOT and fixed the issue by reviewer.
TODO: