Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set classId & methodId for Close method #108

Merged
merged 10 commits into from
Dec 11, 2024
Merged

Conversation

ThisIsNSH
Copy link
Contributor

@ThisIsNSH ThisIsNSH commented Dec 8, 2024

Overview

  • set class id and method id on connection close to give clients the information about the method that caused an "exception" leading to connection close
  • [read more] close in amqp protocol
    • class id: When the close is provoked by a method exception, this is the class of the method.
    • method id: When the close is provoked by a method exception, this is the ID of the method.
  • class id and method id for authentication failure are set to 10/11 i.e. connection/start-ok, as:
    • [code] proxy extracts credentials from the response field in connection/start-ok
    • [code] these credentials are POSTed to auth service
    • [code] in case authentication is failed, it is an "exception" in connection/start-ok, causing connection/close
  • [read more] start-ok in amqp protocol
    • response: opaque data passed to the security mechanism
  • raw protocol
    • start-ok method=11 present in class=10 explaining response field
    • close method=50 present in class=10 explaining classId and methodId field

Testing

  • Unit Tests

@ThisIsNSH ThisIsNSH changed the title Set classId & methodId for methods::ClosePatch 1 Set classId & methodId for methods::Close Dec 8, 2024
@ThisIsNSH ThisIsNSH changed the title Set classId & methodId for methods::Close Set classId & methodId for Close method Dec 8, 2024
@willhoy willhoy merged commit df3e4e1 into bloomberg:main Dec 11, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants