-
Notifications
You must be signed in to change notification settings - Fork 39
fix: Non-Regulated: Required documents in export #5731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Non-Regulated: Required documents in export #5731
Conversation
✅ Deploy Preview for bloom-flagly canceled.
|
✅ Deploy Preview for bloom-angelopolis canceled.
|
✅ Deploy Preview for partners-bloom-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
ludtkemorgan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functionally this works good for the Non-regulated listings/jurisdictions but jurisdictions that don't have it turned on would have all of the Required Documents now in the "Required Documents (Additional Info)". The ticket wasn't very clear about this so here is my recommendation on how this should work:
- There should be one column labeled "Required Documents" that reads from the path "requiredDocuments"
- There should be a column that is labeled "Required Documents List" that reads from path "requiredDocumentsList" (using the helper function you created)
- Only show this column if
enableNonRegulatedfeature flag is enabled for at least one jurisdiction
- Only show this column if
This way it will always show data if it's there.
ludtkemorgan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⭐
This PR addresses #5706
Description
The purpose of this ticket was fix an issue where the data added to the required document column was not being reflected in the export file.
How Can This Be Tested/Reviewed?
Provide instructions so we can review, including any needed configuration, and the test cases that need to be QAd.
Author Checklist:
yarn generate:clientand/or created a migration when requiredReview Process: