Skip to content

Conversation

@millord
Copy link
Collaborator

@millord millord commented Jan 2, 2026

This PR addresses #5706

  • Addresses the issue in full
  • Addresses only certain aspects of the issue

Description

The purpose of this ticket was fix an issue where the data added to the required document column was not being reflected in the export file.

How Can This Be Tested/Reviewed?

  • Log in to core partners as an admin
  • Create or find a listing in the lakeview jurisdiction
  • Select Non-Regulated listing type
  • Add required documents in the checkbox list and copy in the required documents additional info list
  • Save
  • Export the listings export
  • Search for the Required Documents column it should have as value a comma separated list of the required documents.
image

Provide instructions so we can review, including any needed configuration, and the test cases that need to be QAd.

Author Checklist:

  • Added QA notes to the issue with applicable URLs
  • Reviewed in a desktop view
  • Reviewed in a mobile view
  • Reviewed considering accessibility
  • Added tests covering the changes
  • Made corresponding changes to the documentation
  • Ran yarn generate:client and/or created a migration when required

Review Process:

  • Read and understand the issue
  • Ensure the author has added QA notes
  • Review the code itself from a style point of view
  • Pull the changes down locally and test that the acceptance criteria is met
  • Either (1) explicitly ask a clarifying question, (2) request changes, or (3) approve the PR, even if there are very small remaining changes, if you don't need to re-review after the updates

@netlify
Copy link

netlify bot commented Jan 2, 2026

Deploy Preview for bloom-flagly canceled.

Name Link
🔨 Latest commit 396d114
🔍 Latest deploy log https://app.netlify.com/projects/bloom-flagly/deploys/695d9157abcf150008f01aef

@netlify
Copy link

netlify bot commented Jan 2, 2026

Deploy Preview for bloom-angelopolis canceled.

Name Link
🔨 Latest commit 396d114
🔍 Latest deploy log https://app.netlify.com/projects/bloom-angelopolis/deploys/695d91574fad2600089b1d45

@netlify
Copy link

netlify bot commented Jan 2, 2026

Deploy Preview for partners-bloom-dev ready!

Name Link
🔨 Latest commit 396d114
🔍 Latest deploy log https://app.netlify.com/projects/partners-bloom-dev/deploys/695d91579291590008d921aa
😎 Deploy Preview https://deploy-preview-5731--partners-bloom-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@millord millord changed the title added change fix: Non-Regulated: Required documents in export Jan 2, 2026
@millord millord marked this pull request as ready for review January 2, 2026 19:11
@millord millord added the 1 review needed Requires 1 more review before ready to merge label Jan 5, 2026
Copy link
Collaborator

@ludtkemorgan ludtkemorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionally this works good for the Non-regulated listings/jurisdictions but jurisdictions that don't have it turned on would have all of the Required Documents now in the "Required Documents (Additional Info)". The ticket wasn't very clear about this so here is my recommendation on how this should work:

  • There should be one column labeled "Required Documents" that reads from the path "requiredDocuments"
  • There should be a column that is labeled "Required Documents List" that reads from path "requiredDocumentsList" (using the helper function you created)
    • Only show this column if enableNonRegulated feature flag is enabled for at least one jurisdiction

This way it will always show data if it's there.

@ludtkemorgan ludtkemorgan added needs changes The author must make changes and then re-request review before merging and removed 1 review needed Requires 1 more review before ready to merge labels Jan 6, 2026
@millord millord added 1 review needed Requires 1 more review before ready to merge and removed needs changes The author must make changes and then re-request review before merging labels Jan 6, 2026
Copy link
Collaborator

@ludtkemorgan ludtkemorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ludtkemorgan ludtkemorgan added ready to merge Should be applied when a PR has been reviewed and approved and removed 1 review needed Requires 1 more review before ready to merge labels Jan 7, 2026
@millord millord merged commit 66152ab into main Jan 7, 2026
35 checks passed
@millord millord deleted the 5706/non-regulated-required-documents-in-export-api branch January 7, 2026 18:58
@millord millord added ready for qa Ready to be QA’d and removed ready to merge Should be applied when a PR has been reviewed and approved labels Jan 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready for qa Ready to be QA’d

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants