-
Notifications
You must be signed in to change notification settings - Fork 39
feat: New Field - Parking fee #5709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
millord
wants to merge
32
commits into
main
Choose a base branch
from
5676/new-field-parking-fee
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for bloom-flagly canceled.
|
✅ Deploy Preview for bloom-angelopolis canceled.
|
✅ Deploy Preview for partners-bloom-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for bloom-lakeview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for bloom-exygy-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for bloom-public-seeds ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #5676
Description
Please include a summary of the change and which issue(s) is addressed.
The purpose of this ticket was - LA wanted us to add a new parking-related field to the building features section. This field should be under a new feature toggle enableParkingFee and it should only be on in LA / Angelopolis. We will need to add a new field to the listing DTO.
How Can This Be Tested/Reviewed?
Partners
1-Navigate to the partners site
2-Click on add a listing and select any jurisdiction
3-In the listing creating page look for the Building features section
4-at the bottom of that section you should see the new Parking fee field
Public
1-Create a listing in the partners site and add a parking fee to it (is steps above to achieve that)
2-Navigate to the public site
3-Select the listing you created before to navigate to the details page
4-Click on the features toggle (+)
5-You should see the new Parking fee value you previously added
Provide instructions so we can review, including any needed configuration, and the test cases that need to be QAd.
Author Checklist:
yarn generate:clientand/or created a migration when requiredReview Process: