-
Notifications
You must be signed in to change notification settings - Fork 39
5577/property section backend #5693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for partners-bloom-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for bloom-public-seeds ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for bloom-flagly canceled.
|
✅ Deploy Preview for bloom-exygy-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for bloom-angelopolis canceled.
|
…oom-housing/bloom into 5577/property-section-backend
YazeedLoonat
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good, some questions and some requested changes
a must have on this would be unit tests on the service functions
a nice to have would be new permission e2e tests in the permission suites
| PaginationMeta, | ||
| IdDTO, | ||
| ) | ||
| @PermissionTypeDecorator('property') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: this would get this to leverage the old property permissions from permission_policy.csv is that correct or do those perms need to be updated?
This PR addresses #5577
Description
PropertiestableHow Can This Be Tested/Reviewed?
yarn setupcommand to apply the new migration and set up aPropertiestable2a. Create at least two new property entries using the POST
/propertiesendpoint.2b. Retrieve all created properties using the GET
/propertiesendpoint (this step should also be repeated using different query parameters and search filters)2c. Using a generated ID copied from the previous query, retrieve a single property entry using the GET
/properties/<ID>endpoint.2d. Using the same ID, perform the update operation using the PUT
/propertiesendpoint. (The request will return an updated entry, but step2ccan be repeated to ensure that changes have been properly applied)2e. Using the same ID, perform the delete operation DELETE
/propertiesendpoint.Tip
The above steps should also be performed using invalid data, like missing DTO fields, invalid URLs, invalid IDs etc. to ensure proper error and exception handling
Author Checklist:
yarn generate:clientand/or created a migration when requiredReview Process: