fix: move non-regulated selection to jurisdiction modal #5690
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for bloom-lakeview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for partners-bloom-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for bloom-flagly canceled.
|
✅ Deploy Preview for bloom-angelopolis canceled.
|
✅ Deploy Preview for bloom-public-seeds ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for bloom-exygy-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
ludtkemorgan
force-pushed
the
non-regulated-modal
branch
2 times, most recently
from
320128f to
f2d84aa
Compare
ludtkemorgan
commented
Dec 16, 2025
Collaborator
There was a problem hiding this comment.
Nit non-blocking (because smaller screen size on partners) we could add some padding between the options when it switches to vertical
Could we have the order in which the questions appear be the same between the detail and edit pages? Imagining on the detail page we would move up the listing type question
ludtkemorgan
force-pushed
the
non-regulated-modal
branch
from
0ad54c1 to
be3e2f0
Compare
✅ Deploy Preview for bloom-flagly canceled.
|
✅ Deploy Preview for bloom-angelopolis canceled.
|
✅ Deploy Preview for partners-bloom-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
ludtkemorgan
added
the
1 review needed
Collaborator
Author
|
@emilyjablonski Thanks for the review. This is ready to be re-looked at |
emilyjablonski
approved these changes
Jan 6, 2026
Collaborator
emilyjablonski
left a comment
emilyjablonski
left a comment
There was a problem hiding this comment.
This lgtm! The last piece is I think we just introduced some unnecessary padding underneath the dropdown.
PR:
Prod:
emilyjablonski
removed
the
1 review needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #(insert-number-here)
Description
During the development of the non-regulated listing functionality, a number of edge cases were identified related to users switching their selection between "regulated" and "non-regulated" after partially completing the form. This is particularly problematic for unit data and could result in corrupted data, leading to listings that are a hybrid of regulated and non-regulated states.
To prevent this problem we can make the listing type selection earlier in the flow utilizing the new jurisdiction selection modal.
If the user only has access to one jurisdiction and that jurisdiction has
enableNonRegulatedListingsturned on they will only see the Listing Type questionHow Can This Be Tested/Reviewed?
Multiple jurisdictions
One jurisdiction
With the default seeded data this can be hard to test without making some changes since jurisdictional admin is disabled for Lakeview. You can do one of the following steps:
enableNonRegulatedListingsfor a different jurisdiction (Note they will also need to have unit groups enabled)Once the above is done you should be able to go through the "add listing" flow and just see the one question on the modal
additional testing
The following should also be tested
Author Checklist:
yarn generate:clientand/or created a migration when requiredReview Process: