Skip to content

Conversation

@matzduniuk
Copy link
Collaborator

This PR addresses #4996

  • Addresses the issue in full
  • Addresses only certain aspects of the issue

Description

Adds options for the filter drawer using the Core Community Types definitions when the swapCommunityTypeWithPrograms feature flag is disabled.

How Can This Be Tested/Reviewed?

  • Open the Prisma Studio panel and ensure the swapCommunityTypeWithPrograms feature flag is disabled for the public sites currently configured jurisdiction
  • Make sure at least one listing has a reservedCommunityType set
  • Go to the public sites /listings page
  • Click the Filter button
  • Scroll down and verify that the reserved community types section exists
  • Verify that applying the community type filter works

Author Checklist:

  • Added QA notes to the issue with applicable URLs
  • Reviewed in a desktop view
  • Reviewed in a mobile view
  • Reviewed considering accessibility
  • Added tests covering the changes
  • Made corresponding changes to the documentation
  • Ran yarn generate:client and/or created a migration when required

Review Process:

  • Read and understand the issue
  • Ensure the author has added QA notes
  • Review the code itself from a style point of view
  • Pull the changes down locally and test that the acceptance criteria is met
  • Either (1) explicitly ask a clarifying question, (2) request changes, or (3) approve the PR, even if there are very small remaining changes, if you don't need to re-review after the updates

@matzduniuk matzduniuk self-assigned this Sep 4, 2025
@matzduniuk matzduniuk added the 1 review needed Requires 1 more review before ready to merge label Sep 4, 2025
@netlify
Copy link

netlify bot commented Sep 4, 2025

Deploy Preview for partners-bloom-dev ready!

Name Link
🔨 Latest commit 1d83b31
🔍 Latest deploy log https://app.netlify.com/projects/partners-bloom-dev/deploys/68e7b99e9e1b7800082cf20c
😎 Deploy Preview https://deploy-preview-5342--partners-bloom-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Sep 4, 2025

Deploy Preview for bloom-public-seeds ready!

Name Link
🔨 Latest commit 1d83b31
🔍 Latest deploy log https://app.netlify.com/projects/bloom-public-seeds/deploys/68e7b99efee5300008197ad0
😎 Deploy Preview https://deploy-preview-5342--bloom-public-seeds.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Sep 4, 2025

Deploy Preview for bloom-flagly ready!

Name Link
🔨 Latest commit 1d83b31
🔍 Latest deploy log https://app.netlify.com/projects/bloom-flagly/deploys/68e7b99ecae24e00078b87ca
😎 Deploy Preview https://deploy-preview-5342--bloom-flagly.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Sep 4, 2025

Deploy Preview for bloom-exygy-dev ready!

Name Link
🔨 Latest commit b8a71f7
🔍 Latest deploy log https://app.netlify.com/projects/bloom-exygy-dev/deploys/68d169b92504dd000827c53f
😎 Deploy Preview https://deploy-preview-5342--bloom-exygy-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Sep 4, 2025

Deploy Preview for bloom-lakeview ready!

Name Link
🔨 Latest commit 1d83b31
🔍 Latest deploy log https://app.netlify.com/projects/bloom-lakeview/deploys/68e7b99e2da35200077b4adf
😎 Deploy Preview https://deploy-preview-5342--bloom-lakeview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@matzduniuk matzduniuk marked this pull request as ready for review September 8, 2025 08:01
@emilyjablonski emilyjablonski changed the title Feat: add filtering by core community type definitions feat: add filtering by core community type definitions Sep 9, 2025
Copy link
Collaborator

@emilyjablonski emilyjablonski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few notes!
We've lost the check on if there are any community types (programs) before we render the section, so if there are no programs it looks like this:

Image

On a fresh reseed in core in Bloomington, I was able to select a reserved community type in partners that did not appear in the filter drawer. I'm also finding the names of the strings in the filter drawer unexpected, that some are prefixed with Rentals for when I would have expected just the name.
Image

@emilyjablonski emilyjablonski added needs changes The author must make changes and then re-request review before merging and removed 1 review needed Requires 1 more review before ready to merge labels Sep 9, 2025
@ludtkemorgan
Copy link
Collaborator

@matzduniuk is this ready to be reviewed again?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs changes The author must make changes and then re-request review before merging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants