-
Notifications
You must be signed in to change notification settings - Fork 39
feat: add filtering by core community type definitions #5342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for partners-bloom-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for bloom-public-seeds ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for bloom-flagly ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for bloom-exygy-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for bloom-lakeview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
emilyjablonski
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few notes!
We've lost the check on if there are any community types (programs) before we render the section, so if there are no programs it looks like this:
On a fresh reseed in core in Bloomington, I was able to select a reserved community type in partners that did not appear in the filter drawer. I'm also finding the names of the strings in the filter drawer unexpected, that some are prefixed with Rentals for when I would have expected just the name.

|
@matzduniuk is this ready to be reviewed again? |
This PR addresses #4996
Description
Adds options for the filter drawer using the Core Community Types definitions when the
swapCommunityTypeWithProgramsfeature flag is disabled.How Can This Be Tested/Reviewed?
swapCommunityTypeWithProgramsfeature flag is disabled for the public sites currently configured jurisdictionreservedCommunityTypeset/listingspageFilterbuttonAuthor Checklist:
yarn generate:clientand/or created a migration when requiredReview Process: