Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: nestjs template for node 22 #385

Merged
merged 3 commits into from
Feb 12, 2025

Conversation

vmcodes
Copy link
Contributor

@vmcodes vmcodes commented Feb 9, 2025

Relates Issue

Fixed #340

Main changes

Fixes compatibility issues related to NestJS and Node 22

Screenshots

image

Check list

  • [ - ] Project create by create-blocklet can work with npm run dev
  • [ - ] Project create by create-blocklet can work with npm run deploy
  • [ - ] Project create by create-blocklet can work with npm run upload
  • [ - ] If a new version need to be publish, make sure you have run npm run bump-version command

@vmcodes vmcodes changed the title Fix: update deps Fix: nestjs template for node 22 Feb 9, 2025
@vmcodes vmcodes changed the title Fix: nestjs template for node 22 fix: nestjs template for node 22 Feb 9, 2025
Copy link
Collaborator

@LancelotLewis LancelotLewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vmcodes
Copy link
Contributor Author

vmcodes commented Feb 11, 2025

LGTM

@LancelotLewis I wasn't sure if you were waiting for me to merge, but I'm not a maintainer. Let me know if any changes should be made. Thanks.

@LancelotLewis
Copy link
Collaborator

@vmcodes waiting for your Check list done

@vmcodes
Copy link
Contributor Author

vmcodes commented Feb 11, 2025

@LancelotLewis should be okay now, thank you

@LancelotLewis LancelotLewis merged commit 109192c into blocklet:main Feb 12, 2025
7 checks passed
@vmcodes vmcodes deleted the fix-nestjs-node22 branch February 12, 2025 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Error with nestjs in nodejs v22.5.x
2 participants