Skip to content

MB-71607: Fixed data corruption in bolt #2324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abhinavdangeti merged 1 commit into from
Apr 24, 2026
Merged

MB-71607: Fixed data corruption in bolt #2324

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions index/scorch/persister.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1232,9 +1232,10 @@ func (s *Scorch) removeBoltFileWriterIDs(ids map[string]struct{}) error {
if err != nil {
return fmt.Errorf("unable to load correct reader: %v", err)
}
c := snapshots.Cursor()
for kk, _ := c.First(); kk != nil; kk, _ = c.Next() {
if k[0] == util.BoltInternalKey[0] {

cc := snapshot.Cursor()
for kk, _ := cc.First(); kk != nil; kk, _ = cc.Next() {
if kk[0] == util.BoltInternalKey[0] {
internalBucket := snapshot.GetBucket(kk)
if internalBucket == nil {
continue
Expand Down
2 changes: 2 additions & 0 deletions util/bolt.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,7 @@ func (b *BoltBucketImpl) CreateBucketIfNotExists(name []byte) (*BoltBucketImpl,
func (b *BoltBucketImpl) ForEach(fn func(key []byte, value []byte) error, reader FileReader) error {
_, ok1 := boltKeysProcessed[b.name]
return b.Bucket.ForEach(func(k, v []byte) error {
v = append([]byte(nil), v...)
if _, ok2 := boltKeysProcessed[string(k)]; ok1 || ok2 {
if reader == nil {
return fmt.Errorf("reader callback is required for bucket %s", b.name)
Expand All @@ -136,6 +137,7 @@ func (b *BoltBucketImpl) ForEach(fn func(key []byte, value []byte) error, reader
func (b *BoltBucketImpl) Put(key []byte, value []byte, writer FileWriter) error {
_, ok1 := boltKeysProcessed[string(key)]
_, ok2 := boltKeysProcessed[b.name]
value = append([]byte(nil), value...)
if ok1 || ok2 {
if writer == nil {
return fmt.Errorf("writer callback is required for key %s", string(key))
Expand Down
Loading