Conversation
Likith101
requested review from
CascadingRadium,
Thejas-bhat,
abhinavdangeti,
capemox and
maneuvertomars
Member
Author
|
Not fully sure why this is the case, but the prettifier I use changed the formatting in a few extra places. It doesn't seem like anything changed visually so I didn't exclude it from the PR |
|
coverage: 51.862% (+0.02%) from 51.844% — docs into master |
Member
|
@Likith101 would you rebase this over #2320. Also it seems we're touching a lot of lines we don't need to here, would you fix that. |
abhinavdangeti
changed the title
Member
Author
|
I do not think an additional change is necessary here. #2320 seems to cover BQ and rabitq at a similar level of depth as compared to the rest of the vector types. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.