Skip to content

Better types for tickets #445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 25, 2025
Merged

Better types for tickets #445

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bd605a4
chore: enforce `getComments` to `TicketComment[]`
jakehwll Sep 2, 2025
8ec9ab2
chore: enforce `listCollaborators` to `TicketCollaborator[]`
jakehwll Sep 2, 2025
3a34fa6
chore: enforce `listIncidents` to `Ticket[]`
jakehwll Sep 2, 2025
6df9710
Merge branch 'master' into master
blakmatrix Sep 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/clients/core/tickets.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,12 @@ const {Client} = require('../client');
*/

/**
* @typedef {object} TicketCollaborator
* @property {number} id - The ID of the collaborator.
* @property {string} name - The name of the collaborator.
*/

/**
* @typedef {object} Via
* @property {string} [channel] - How the ticket or event was created expressed as a via type or via id
* @property {object} source - For some channels a source object gives more information about how or why the ticket or event was created
Expand Down Expand Up @@ -244,7 +250,7 @@ class Tickets extends Client {
/**
* List collaborators of a specific ticket.
* @param {number} ticketId - The ID of the ticket.
* @returns {Promise<Array>} An array of collaborators for the ticket.
* @returns {Promise<Array<TicketCollaborator>>} An array of collaborators for the ticket.
* @see {@link https://developer.zendesk.com/api-reference/ticketing/tickets/tickets/#list-tickets}
* @example
* const collaborators = await client.tickets.listCollaborators(7890);
Expand All @@ -256,7 +262,7 @@ class Tickets extends Client {
/**
* List incidents related to a specific ticket.
* @param {number} ticketId - The ID of the ticket.
* @returns {Promise<Array>} An array of incidents related to the ticket.
* @returns {Promise<Array<Ticket>>} An array of incidents related to the ticket.
* @see {@link https://developer.zendesk.com/api-reference/ticketing/tickets/tickets/#list-tickets}
* @example
* const incidents = await client.tickets.listIncidents(7890);
Expand Down