Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update FFmpeg to ensure compatibility with newer kernels #16027

Merged
merged 1 commit into from
Jan 18, 2025

Conversation

MarcA711
Copy link
Contributor

@MarcA711 MarcA711 commented Jan 17, 2025

Proposed change

An update of the VPU driver in the current vendor kernel causes incompatibilities with the current FFmpeg version (see #16006 (comment)). This PR updates FFmpeg to fix this. The timing is bad because the new version wasn't tested in depth. However, I think it would still be good to ship v0.15 with the new version.

Two users want to test the new version. Once they confirm that everything works, I will request reviewing/ merging this PR.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code
  • Documentation Update

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • The code has been formatted using Ruff (ruff format frigate)

Copy link

netlify bot commented Jan 17, 2025

Deploy Preview for frigate-docs canceled.

Name Link
🔨 Latest commit 672b633
🔍 Latest deploy log https://app.netlify.com/sites/frigate-docs/deploys/678ac14fcb6776000859f019

@MarcA711
Copy link
Contributor Author

Both users confirmed that the updated FFmpeg works and fixes the problem. This PR can now be merged.

Many thanks @GMagician and @ragenhe for reporting the issue and and testing the fix.

@MarcA711 MarcA711 marked this pull request as ready for review January 18, 2025 12:24
@NickM-27 NickM-27 merged commit 3947e79 into blakeblackshear:dev Jan 18, 2025
9 checks passed
@MarcA711 MarcA711 deleted the patch-2 branch January 18, 2025 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants