-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjusted mclmc static #764
Adjusted mclmc static #764
Conversation
Let me know when it is ready for review |
@junpenglao Should be ready. Tests seem to be taking a while - not sure why. |
Seems there are some tests fail |
Hmm, it seems that |
Let me rerun manually |
hmmm not sure why the test is getting hung up near the end, let me try to delete the cache. |
hmm same problem that test hang at 95-96%... the reason is not obvious to me. @reubenharry could you close this PR and start afresh? sorry about the trouble |
Sure, can do! |
Dynamic and static adjusted mclmc
As with HMC, I separate (adjusted) MCLMC into static and dynamic variants, i.e. with and without randomized trajectory length.
I also changed for using
sqrt_diag_cov
toinverse_mass_matrix
(i.e. the square ofsqrt_diag_cov
) because this is in keeping with the naming scheme for other algorithms. This requires a change in the adaptation scheme and the integrator, but a straightforward one.This PR is motivated by an upcoming ensemble method.
A few important guidelines and requirements before we can merge your PR:
main
commit;pre-commit
is installed and configured on your machine, and you ran it before opening the PR;Consider opening a Draft PR if your work is still in progress but you would like some feedback from other contributors.