-
-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TravisCI configuration #11
Conversation
Added TravisCI configuration to speed up the integration of new changes.
- composer self-update | ||
|
||
install: | ||
- composer install --prefer-source --no-interaction --no-progress |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about removing --prefer-source
and also cache the Composer cache files between builds?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I included the --prefer-source
because could be useful if some dependencies' development tools want be used, for example the Guzzle tests/server.js
, so it's up to this repo owner, imo it's just a decision.
Composer cache: 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, if I am not mistaken, caching the Composer cache files won't work when installing from source instead of from dist.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right, I didn't see the related PR, do you suggest to add the --prefer-dist
and something to configure the token too?
cache: | ||
directories: | ||
- vendor | ||
- $HOME/.composer/cache |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.composer/cache/files
would be enough, to avoid invalidating the cache because of Packagist metadata
|
||
cache: | ||
directories: | ||
- vendor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would not cache the vendor
folder:
- it can create weird issues if the cache gets corrupted, as Composer will still see the packages as being here
- it will invalidate the Travis cache on each build due to the autoloader being regenerated
- it does not bring much benefit, as installing archives from the cache is fast already
👍 |
1 similar comment
👍 |
14ea3f2
to
abc38e8
Compare
Added TravisCI configuration to speed up the integration of new changes.
Related: #5