Fix O(n^2) slow fd_write #95
Conversation
|
Please move the dependency updates to a separate commit and skip the version bump commit. |
TerrorJack
force-pushed
the
fix-slow-fd-write
branch
from
5934500 to
d42058c
Compare
|
I meant separate PR, not commit. My bad. |
|
At the very least, typescript must be bumped, otherwise the baseline 2024 arraybuffer grow type signature as well as the |
|
The dependency bump PR could be merged first. |
TerrorJack
force-pushed
the
fix-slow-fd-write
branch
from
d42058c to
8e4b2e9
Compare
| newData = new Uint8Array(newBuffer); | ||
| newData.set(data); | ||
| return newData; | ||
| } |
There was a problem hiding this comment.
This function has inconsistent indentation. I don't know why prettier doesn't complain about this.
There was a problem hiding this comment.
This is not inconsistent, this is multiple constant bindings in a single const declaration, so newData is one increased level of indentation here.
| const newBuffer = new ArrayBuffer(newDataSize, { | ||
| maxByteLength: newDataSize, | ||
| }), | ||
| newData = new Uint8Array(newBuffer); |
There was a problem hiding this comment.
This is missing a const newData, right?
2 participants
Closes #93. Note that I've also taken some time to upgrade all the outdated dependencies and fix the code accordingly, if you wouldn't mind.