Skip to content

fix(nix): update toolchain and vendor hash - #672

Closed
mi-skam wants to merge 1 commit into
bjarneo:mainfrom
mi-skam:fix/nix-build
Closed

mi-skam wants to merge 1 commit into
bjarneo:mainfrom
mi-skam:fix/nix-build

Conversation

@mi-skam

@mi-skam mi-skam commented Oct 30, 2026 •

Copy link
Copy Markdown

Summary

  • Update the nixos-unstable lock to nixpkgs 31ecbaca1bdefa45dffc409f0250bd8039ea0010, supplying Go 1.26.10 as required by go.mod (the previous lock supplied Go 1.26.7).
  • Refresh the Go vendor hash to match the generated dependencies.
  • No application source changes.

Verification

  • Confirmed the selected Go version is 1.26.10.
  • Successfully built and installed on aarch64-darwin using nix profile add ., including the package build checks.
  • Linux builds have not been verified.

Summary by CodeRabbit

  • Chores
    • Updated the package build configuration to use the current dependency checksum. This change is limited to packaging and does not change the app’s features, workflows, or user-facing behavior. No other user-visible changes are included in this update.

The locked nixpkgs supplied Go 1.26.7, below go.mod's required 1.26.10. Refresh nixpkgs and the stale Go vendor hash so the flake builds again.

Verified on aarch64-darwin with nix profile add ., completing the Nix build, checks, and installation.
@coderabbitai

coderabbitai Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Repository UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: d09faab2-6b10-4eb5-bac5-05cd81658e59
Commits

Reviewing files that changed from the base of the PR and between 02309c9 and 4f38b88.

Files ignored due to path filters: 1
  • flake.lock is excluded by !**/*.lock
Files selected for processing: 1
  • nix/package.nix

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.

Walkthrough

The Nix package definition now uses an updated vendorHash value for Go dependencies.

Changes: Nix package build

Layer / File(s) Summary
Update Go dependency vendor hash
nix/package.nix
The vendorHash value used by buildGoModule changed.

Priority: Normal

Estimated code review effort: 1 (Trivial) | ~3 minutes

Possibly related PRs

Suggested reviewers: bjarneo, legacynode

Merge Risk: Minimal · up to 4f38b

No actionable merge-blocking risk was identified in the reviewed change.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title "fix(nix): update toolchain and vendor hash" matches the main change. The PR updates the nixos-unstable lock to a nixpkgs revision that supplies Go 1.26.10 instead of Go 1.26.7, and it refre…
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title "fix(nix): update toolchain and vendor hash" matches the main change. The PR updates the nixos-unstable lock to a nixpkgs revision that supplies Go 1.26.10 instead of Go 1.26.7, and it refreshes the Go vendor hash in nix/package.nix. The title names both parts of the change. It uses a conventional commit prefix and is specific enough for a teammate scanning history.

Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@bjarneo

bjarneo commented Nov 5, 2026

Copy link
Copy Markdown
Owner

Thanks for this fix. #651 added new modules to main after this PR, so this vendorHash no longer matches. #655 sets a new hash and passes Nix on the current main, so we merged #655 and I close this PR. A follow-up PR that updates flake.lock and goes back to the default go is welcome.

@bjarneo bjarneo added the duplicate This issue or pull request already exists label Nov 5, 2026
@bjarneo bjarneo closed this Nov 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

duplicate This issue or pull request already exists

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants