Skip to content

Conversation

@eliykat
Copy link
Member

@eliykat eliykat commented Dec 3, 2025

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-28487

📔 Objective

Update code ownership of Events and EventsProcessor projects to the Data Insights and Reporting Team (DIRT), as the new owners of the organization events domain.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@eliykat eliykat requested a review from ttalty December 3, 2025 04:09
@codecov
Copy link

codecov bot commented Dec 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 53.86%. Comparing base (3de2f98) to head (89ca97e).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6678   +/-   ##
=======================================
  Coverage   53.86%   53.86%           
=======================================
  Files        1917     1917           
  Lines       85126    85126           
  Branches     7620     7620           
=======================================
  Hits        45853    45853           
  Misses      37508    37508           
  Partials     1765     1765           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2025

Logo
Checkmarx One – Scan Summary & Detailsccc45fe1-3d9d-4261-9cc2-773cd49c370e

New Issues (2)

Checkmarx found the following issues in this Pull Request

Severity Issue Source File / Package Checkmarx Insight
MEDIUM CSRF /src/Api/Vault/Controllers/CiphersController.cs: 1519
detailsMethod at line 1519 of /src/Api/Vault/Controllers/CiphersController.cs gets a parameter from a user request from id. This parameter value flows ...
ID: dMGF5qNfAN72zlvQcA1MgbhHv%2Fc%3D
Attack Vector
MEDIUM CSRF /src/Api/Vault/Controllers/CiphersController.cs: 1395
detailsMethod at line 1395 of /src/Api/Vault/Controllers/CiphersController.cs gets a parameter from a user request from id. This parameter value flows ...
ID: iOCFr11iI9znjDnv46yLfiS4aDY%3D
Attack Vector
Fixed Issues (2)

Great job! The following issues were fixed in this Pull Request

Severity Issue Source File / Package
MEDIUM CSRF /src/Api/AdminConsole/Public/Controllers/MembersController.cs: 207
MEDIUM CSRF /src/Api/Vault/Controllers/CiphersController.cs: 300

@claude
Copy link
Contributor

claude bot commented Dec 8, 2025

Claude finished @eliykat's task —— View job


Code Review Complete ✅

Task List

  • Review PR changes
  • Verify directories exist
  • Check CODEOWNERS format

Review Summary

This PR cleanly transfers ownership of the Events and EventsProcessor projects from the Admin Console team to the DIRT (Data Insights and Reporting Team). The changes are straightforward and well-organized.

Changes

The PR modifies .github/CODEOWNERS to:

  • Add 5 entries under the DIRT team section (lines 56-60):
    • src/Events
    • src/EventsProcessor
    • test/Events.IntegrationTest
    • test/Events.Test
    • test/EventsProcessor.Test
  • Remove 2 entries from the Admin Console team section (previously lines 66-67):
    • src/Events
    • src/EventsProcessor

Observations

Proper placement: The new entries are correctly placed in the DIRT team section (lines 54-60), maintaining the logical grouping structure of the file.

Complete coverage: All related directories are included:

  • Source projects: src/Events, src/EventsProcessor
  • Test projects: test/Events.IntegrationTest, test/Events.Test, test/EventsProcessor.Test

Clean removal: The old ownership entries were properly removed from the Admin Console section.

Alphabetical ordering: Within the DIRT section, entries are properly ordered (Dirt wildcard, then Events/EventsProcessor alphabetically).

All directories verified: Confirmed all referenced directories exist in the repository.

Minor Observations

📝 The test projects are now explicitly listed under DIRT ownership. Previously, only the source projects (src/Events, src/EventsProcessor) were explicitly listed under Admin Console. The test directories may have been covered by wildcards or default ownership rules before. This change makes ownership more explicit, which is a good practice.

Recommendation

Approve - This is a clean ownership transfer that follows the CODEOWNERS file conventions and completely covers all relevant directories for the Events domain.


@eliykat eliykat requested a review from a team December 12, 2025 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants