-
Notifications
You must be signed in to change notification settings - Fork 1.5k
[PM-28487] Move Events and EventsProcessor to DIRT ownership #6678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[PM-28487] Move Events and EventsProcessor to DIRT ownership #6678
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6678 +/- ##
=======================================
Coverage 53.86% 53.86%
=======================================
Files 1917 1917
Lines 85126 85126
Branches 7620 7620
=======================================
Hits 45853 45853
Misses 37508 37508
Partials 1765 1765 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
New Issues (2)Checkmarx found the following issues in this Pull Request
|
|
Claude finished @eliykat's task —— View job Code Review Complete ✅Task List
Review SummaryThis PR cleanly transfers ownership of the Events and EventsProcessor projects from the Admin Console team to the DIRT (Data Insights and Reporting Team). The changes are straightforward and well-organized. ChangesThe PR modifies
Observations✅ Proper placement: The new entries are correctly placed in the DIRT team section (lines 54-60), maintaining the logical grouping structure of the file. ✅ Complete coverage: All related directories are included:
✅ Clean removal: The old ownership entries were properly removed from the Admin Console section. ✅ Alphabetical ordering: Within the DIRT section, entries are properly ordered (Dirt wildcard, then Events/EventsProcessor alphabetically). ✅ All directories verified: Confirmed all referenced directories exist in the repository. Minor Observations📝 The test projects are now explicitly listed under DIRT ownership. Previously, only the source projects ( RecommendationApprove - This is a clean ownership transfer that follows the CODEOWNERS file conventions and completely covers all relevant directories for the Events domain. |
…for-event-projects


🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-28487
📔 Objective
Update code ownership of
EventsandEventsProcessorprojects to the Data Insights and Reporting Team (DIRT), as the new owners of the organization events domain.📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes