Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move CSVHelper under billing ownership #5156

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

djsmith85
Copy link
Contributor

📔 Objective

Looking at the Dependency Dashboard I noticed that CSVHelperhad no owner. Looking at the imports it's currently only used by @bitwarden/team-billing-dev. Assigning them the ownership.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@djsmith85 djsmith85 requested a review from a team December 16, 2024 16:05
@djsmith85 djsmith85 enabled auto-merge (squash) December 16, 2024 16:05
@djsmith85 djsmith85 merged commit d88a103 into main Dec 16, 2024
45 checks passed
@djsmith85 djsmith85 deleted the renovate/move-CSVHelper-under-Billing-ownership branch December 16, 2024 16:11
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.00%. Comparing base (8994d1d) to head (eb86351).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5156      +/-   ##
==========================================
+ Coverage   42.98%   43.00%   +0.01%     
==========================================
  Files        1446     1447       +1     
  Lines       66150    66164      +14     
  Branches     6060     6062       +2     
==========================================
+ Hits        28437    28455      +18     
+ Misses      36431    36427       -4     
  Partials     1282     1282              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Detailsdf7b88ee-809f-4c63-96a9-2a57376f1417

Fixed Issues

Severity Issue Source File / Package
MEDIUM CSRF /src/Api/Auth/Controllers/AccountsController.cs: 967
LOW Log_Forging /src/Api/Auth/Controllers/AccountsController.cs: 967

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants