-
Notifications
You must be signed in to change notification settings - Fork 24
[PM-27231] Account registration v2 for key connector #611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[PM-27231] Account registration v2 for key connector #611
Conversation
|
Great job! No new security vulnerabilities introduced in this pull request |
…ector # Conflicts: # crates/bitwarden-core/src/key_management/crypto_client.rs # crates/bitwarden-crypto/src/keys/mod.rs
🔍 SDK Breaking Change Detection ResultsSDK Version:
Breaking change detection completed. View SDK workflow |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #611 +/- ##
==========================================
- Coverage 78.57% 78.28% -0.29%
==========================================
Files 283 285 +2
Lines 29188 29298 +110
==========================================
+ Hits 22934 22937 +3
- Misses 6254 6361 +107 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
|
||
| /// Initializes a new cryptographic state for a user and posts it to the server; enrolls the | ||
| /// user to key connector unlock. | ||
| pub async fn post_keys_for_key_connector_registration( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Relaying feedback I got on my PR here, we probably want unit tests on this. Vault has some examples for this, but it generally involves moving the impl into a separate function that you pass in the "api client" dependency and other parameters to, then the test can replace that with a mocked api client.

🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-27231
📔 Objective
Account registration V2 for key connector.
Added
KeyConnectorKey, since we have to migrate fromMasterKeyfor key connector at some point.Added Key Connector API client, can set the key connector key for the user into the Key Connector server.
Requires autogenerated openapi models from bitwarden/server#6712. For the build sake process, included in the PR, will resolve once in SDK.
Partially based on the approach in #596 for consistency across all V2 account registrations.
Test coverage coming up soon.
🚨 Breaking Changes
No changes to account registration V1.
⏰ Reminders before review
team
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes