Skip to content

[PM-25820] - Implement the ability to delete an attachment #557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
+474 −0
Draft

[PM-25820] - Implement the ability to delete an attachment #557

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
82dbf96
Implement the ability to delete an attachment
theMickster Nov 13, 2025
5c89411
Implement suggestions for code improvement
theMickster Nov 13, 2025
038a9ef
Changes to error handling
theMickster Nov 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion crates/bitwarden-vault/src/cipher/cipher.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
use bitwarden_api_api::{
apis::ciphers_api::{PutShareError, PutShareManyError},
apis::ciphers_api::{
DeleteAttachmentAdminError, DeleteAttachmentError, PutShareError, PutShareManyError,
},
models::{
CipherDetailsResponseModel, CipherRequestModel, CipherResponseModel,
CipherWithIdRequestModel,
Expand Down Expand Up @@ -72,6 +74,10 @@ pub enum CipherError {
Chrono(#[from] chrono::ParseError),
#[error(transparent)]
SerdeJson(#[from] serde_json::Error),
#[error(transparent)]
DeleteAttachment(#[from] bitwarden_api_api::apis::Error<DeleteAttachmentError>),
#[error(transparent)]
DeleteAttachmentAdmin(#[from] bitwarden_api_api::apis::Error<DeleteAttachmentAdminError>),
}

/// Helper trait for operations on cipher types.
Expand Down
Loading
Loading