Skip to content

Conversation

@JaredSnider-Bitwarden
Copy link
Contributor

…level API.

🎟️ Tracking

📔 Objective

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@JaredSnider-Bitwarden JaredSnider-Bitwarden changed the title Auth/PM-14922 - Identity Client - Offer get_password_prelogin_data as top … Auth/PM-14922 - Identity Client - WIP Nov 7, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2025

Logo
Checkmarx One – Scan Summary & Details2dd0b6ba-3396-4627-ab5d-40d122411a6a

Great job! No new security vulnerabilities introduced in this pull request

@codecov
Copy link

codecov bot commented Nov 7, 2025

Codecov Report

❌ Patch coverage is 57.32899% with 131 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.48%. Comparing base (c60a5d7) to head (2c409e1).
⚠️ Report is 17 commits behind head on main.

Files with missing lines Patch % Lines
...warden-auth/src/identity/api/send_login_request.rs 0.00% 35 Missing ⚠️
...y/login_via_password/password_login_api_request.rs 0.00% 25 Missing ⚠️
...auth/src/identity/api/request/login_api_request.rs 0.00% 23 Missing ⚠️
.../identity/login_via_password/login_via_password.rs 0.00% 17 Missing ⚠️
...c/identity/login_via_password/prelogin_password.rs 90.30% 16 Missing ⚠️
crates/bitwarden-auth/src/api/enums/scope.rs 0.00% 12 Missing ⚠️
.../identity/api/response/login_error_api_response.rs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #549      +/-   ##
==========================================
- Coverage   79.94%   79.48%   -0.47%     
==========================================
  Files         298      310      +12     
  Lines       32129    32548     +419     
==========================================
+ Hits        25686    25871     +185     
- Misses       6443     6677     +234     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…rd_prelogin file to prevent identity client file from growing substantially as we add items (per feedback from platform)
…d suffixed (2) Add required mod declarations for usages to show up and fix imports.
…d required scopes for standard BW user and mechanism for converting array of scopes to space separated string (3) UserTokenApiRequest - build constructor with default scopes already included
@github-actions
Copy link
Contributor

github-actions bot commented Nov 14, 2025

🔍 SDK Breaking Change Detection Results

SDK Version: auth/pm-14922/mp-login (2c409e1)
Completed: 2025-11-21 00:01:27 UTC
Total Time: 247s

Client Status Details
typescript ✅ No breaking changes detected TypeScript compilation passed with new SDK version - View Details

Breaking change detection completed. View SDK workflow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants