-
Notifications
You must be signed in to change notification settings - Fork 25
Auth/PM-14922 - Identity Client - WIP #549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Great job! No new security vulnerabilities introduced in this pull request |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #549 +/- ##
==========================================
- Coverage 79.94% 79.48% -0.47%
==========================================
Files 298 310 +12
Lines 32129 32548 +419
==========================================
+ Hits 25686 25871 +185
- Misses 6443 6677 +234 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…rd_prelogin file to prevent identity client file from growing substantially as we add items (per feedback from platform)
…d suffixed (2) Add required mod declarations for usages to show up and fix imports.
…ationData usage in bitwarden-auth crate
…d required scopes for standard BW user and mechanism for converting array of scopes to space separated string (3) UserTokenApiRequest - build constructor with default scopes already included
…req + MP authN data to api payload
🔍 SDK Breaking Change Detection ResultsSDK Version:
Breaking change detection completed. View SDK workflow |
…in_request to api as it makes more sense as an api service layer esque thing.
… out more models that I have to build

…level API.
🎟️ Tracking
📔 Objective
⏰ Reminders before review
team
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes