Skip to content

Conversation

coroiu
Copy link
Contributor

@coroiu coroiu commented Sep 30, 2025

🎟️ Tracking

📔 Objective

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

github-actions bot commented Sep 30, 2025

Logo
Checkmarx One – Scan Summary & Detailsb5b04000-6747-4cdb-8cef-3ab80d1df393

Great job! No new security vulnerabilities introduced in this pull request

Copy link

codecov bot commented Sep 30, 2025

Codecov Report

❌ Patch coverage is 0% with 24 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.04%. Comparing base (9574bd0) to head (46b59e6).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/bitwarden-wasm-internal/src/client.rs 0.00% 7 Missing ⚠️
...nse/bitwarden-commercial-vault/src/vault_client.rs 0.00% 6 Missing ⚠️
crates/bitwarden-pm/src/commercial.rs 0.00% 6 Missing ⚠️
crates/bitwarden-pm/src/lib.rs 0.00% 3 Missing ⚠️
...rden_license/bitwarden-commercial-vault/src/lib.rs 0.00% 1 Missing ⚠️
...e/bitwarden-commercial-vault/src/uniffi_support.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #479      +/-   ##
==========================================
- Coverage   78.10%   78.04%   -0.07%     
==========================================
  Files         283      287       +4     
  Lines       27628    27651      +23     
==========================================
  Hits        21579    21579              
- Misses       6049     6072      +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@coroiu coroiu force-pushed the PM-25568-build-bitwarden-commercial-sdk-internal-in-sdk branch from a53b233 to 3cb6878 Compare October 7, 2025 14:33
@coroiu coroiu marked this pull request as ready for review October 7, 2025 14:40
@coroiu coroiu requested a review from a team as a code owner October 7, 2025 14:40
@coroiu coroiu requested a review from dereknance October 7, 2025 14:40
Copy link

sonarqubecloud bot commented Oct 7, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant