Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PAS-587 | Fix type definitions #87

Closed
wants to merge 1 commit into from
Closed

PAS-587 | Fix type definitions #87

wants to merge 1 commit into from
+1 −1

Conversation

jonashendrickx
Copy link
Member

@jonashendrickx jonashendrickx commented Nov 6, 2024 •
edited by jira bot
Loading

Ticket

Description

Shape

Screenshots

Checklist

I did the following to ensure that my changes were tested thoroughly:

  • __

I did the following to ensure that my changes do not introduce security vulnerabilities:

  • __

@jonashendrickx jonashendrickx requested a review from a team as a code owner November 6, 2024 13:34
abergs
abergs requested changes Nov 6, 2024
View reviewed changes
Copy link
Member

@abergs abergs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue: Does not include all types. See competing fix: #88

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abergs abergs abergs requested changes

@jrmccannon jrmccannon jrmccannon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonashendrickx @abergs @jrmccannon