Skip to content

Conversation

matt-livefront
Copy link
Collaborator

@matt-livefront matt-livefront commented Oct 7, 2025

🎟️ Tracking

PM-24482

📔 Objective

Updates the refresh access token handling to align with other clients.

  • If there's < 5 minutes before the access token expires, preemptively refresh it.
  • If refreshing the token returns a 401 or 403, log the user out.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@matt-livefront matt-livefront requested a review from a team as a code owner October 7, 2025 14:58
Copy link
Contributor

github-actions bot commented Oct 7, 2025

Logo
Checkmarx One – Scan Summary & Detailsd4d4afc1-c171-4e5d-b157-106e4396e1b4

Great job! No new security vulnerabilities introduced in this pull request

Copy link

codecov bot commented Oct 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.77%. Comparing base (4d1dca1) to head (823ab29).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2024      +/-   ##
==========================================
- Coverage   81.33%   75.77%   -5.57%     
==========================================
  Files         831     1017     +186     
  Lines       52439    62024    +9585     
==========================================
+ Hits        42651    46997    +4346     
- Misses       9788    15027    +5239     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@matt-livefront matt-livefront merged commit 4376077 into main Oct 8, 2025
13 of 14 checks passed
@matt-livefront matt-livefront deleted the matt/PM-24482-token-refresh branch October 8, 2025 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants