Skip to content

Conversation

mKoonrad
Copy link

🎟️ Tracking

📔 Objective

I removed many unused strings. I checked manually each strings. Some of strings was related to Android app.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@mKoonrad mKoonrad requested review from matt-livefront and a team as code owners September 29, 2025 11:51
@bitwarden-bot
Copy link

Thank you for your contribution! We've added this to our internal tracking system for review.
ID: PM-26292
Link: https://bitwarden.atlassian.net/browse/PM-26292

Details on our contribution process can be found here: https://contributing.bitwarden.com/contributing/pull-requests/community-pr-process.

@bitwarden-bot bitwarden-bot changed the title Remove unused strings [PM-26292] Remove unused strings Sep 29, 2025
Copy link
Contributor

@KatherineInCode KatherineInCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😮 Impressive! Did you do this by manually going string by string? Or did you have some sort of automated process for identifying candidates, that you then checked manually?

@mKoonrad
Copy link
Author

Ha! 😄 I took message's keys and searched for the number of occurrences in code. I marked as candidates keys with 0 occurrences.

It wasn't perfect method. I think there should be better tools (and I'm thinking why I need to do it). But as you can see, I have more enthusiasm than dev experience 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants