Skip to content
This repository was archived by the owner on Mar 6, 2025. It is now read-only.

Update SonarQube GitHub Action #221

Merged
merged 2 commits into from
Jan 29, 2025
Merged

Conversation

mandreko-bitwarden
Copy link
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/VULN-126

📔 Objective

Migrate to the unified GitHub action for SonarQube. Current latest version is 4.2.1.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@mandreko-bitwarden mandreko-bitwarden requested a review from a team as a code owner January 13, 2025 17:26
Copy link
Contributor

github-actions bot commented Jan 13, 2025

Logo
Checkmarx One – Scan Summary & Details95510a06-60d4-4359-8312-3372270bcbd7

Great job, no security vulnerabilities found in this Pull Request

Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.26%. Comparing base (af57555) to head (4a887e6).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #221   +/-   ##
=======================================
  Coverage   70.26%   70.26%           
=======================================
  Files         215      215           
  Lines        9873     9873           
=======================================
  Hits         6937     6937           
  Misses       2936     2936           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mandreko-bitwarden mandreko-bitwarden self-assigned this Jan 21, 2025
@mandreko-bitwarden mandreko-bitwarden merged commit c6d53a4 into main Jan 29, 2025
9 checks passed
@mandreko-bitwarden mandreko-bitwarden deleted the sonarqube-scan-action-4.2.1 branch January 29, 2025 15:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants