Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BWA-130] Upgrade to Xcode 16.1 #217

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

brant-livefront
Copy link
Collaborator

@brant-livefront brant-livefront commented Dec 26, 2024

๐ŸŽŸ๏ธ Tracking

BWA-130

๐Ÿ“” Objective

I saw a ticket for this and had some extra time, so I thought I'd take shot at upgrading to Xcode 16.1. This PR updates screenshots and the test assertion to run everything on iPhone 16 Pro and inside of Xcode 16.1. It also cleans up some of the warnings generated in Xcode 16.1 and (hopefully) updates the GitHub actions (will test once this is run as a PR). I also tried to copy the changes made to README and other places when we moved the main PW app over to 16.1

โฐ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

Copy link
Contributor

Logo
Checkmarx One โ€“ Scan Summary & Details โ€“ 554a9842-a695-4da7-a05b-d10fee08d150

No New Or Fixed Issues Found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant