Implement rate limiting #4
Conversation
|
+1 i need this |
|
+1 same here, a welcome feature to help control API usage. |
|
Why is this still open? Is the Bitvavo developers team really small? |
| foreach ($header as $h) { | ||
| if (preg_match('/^bitvavo-ratelimit-(limit|remaining|resetat): +(\d+)$/', $h, $match)) { | ||
| list(, $key, $value) = $match; | ||
| $this->ratelimit[$key] = (int) $value; |
There was a problem hiding this comment.
This is very usefull.
One small bugfix for this PR on 32 bit systems.
Casting the resetat key to int will result in a max value of an int32: 2147483647
Casting to a float resolves this problem.
$this->ratelimit[$key] = (float)$value;
|
Kudos, SonarCloud Quality Gate passed!
|
1 similar comment
|
Kudos, SonarCloud Quality Gate passed!
|
|
Is this still not implemented? |
Nope, sadly not |
$bitvavoobject