Conversation
…ke (instead of transceiver)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What (what did you do)
This pr separates the user data handshake, which previously was intertwined in the transceiver code, into its own function.
This
userDataHandshakefunction is still applied within the transceiver function, so all this does is define an explicit wire interface between the handshake and transceiver (and splits up the logic accordingly, which is harder than one might think). This is pr 1 of a multi pr change:pr 1: Separate handshake logic from transceiver logic
pr 2: separate
InputandOutputinto inputs/outputs for handshake and transceiver. Have handshake and transceiver connected circuits, rather than handshake inside transceiverpr 3: move handshake behind the elastic buffer and get rid of all handshake CDC logic (since everything will now be in
txdomain)There were also minor renamings and refactors, just because it seemed appropriate and made my life saner.
Why (context, issues, etc.)
#1199
Dear reviewer (anything you'd like the reviewer to pay close attention to?)
Because this is pr 1, there are a few things that aren't so tidy. Namely, the userDataHandshake signature is quite large (should be a data type, in next PR) and there are comments explaining why I'm doing certain things. Happy to discuss them, but the answer might be "because it makes PR 2 easier".
AI disclaimer (heads-up for more than inline autocomplete)
No
TODO
Cross-outany that do not apply[ ] Write (regression) test[ ] Update documentation, includingdocs/