Introduce counterSource to more easily distribute the counter#1186
Draft
Introduce counterSource to more easily distribute the counter#1186
counterSource to more easily distribute the counter#1186Conversation
13e0a09 to
b92f23d
Compare
13e0a09 to
63ef605
Compare
63ef605 to
b499ee8
Compare
counterSource to more easily distribute the counter
Contributor
The reset should be aligned with what the counter calls "zero", but it's okay if it looks like this: I think that's what you're currently doing, but you could make it more obvious by adjusting the initial contents of the counter to be |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What (what did you do)
Make counter distribution consistent across demos.
Why (context, issues, etc.)
To improve both consistency and routing in of the different demos.
Dear reviewer (anything you'd like the reviewer to pay close attention to?)
Does it matter that we now get undefined contents out of the counter for the first n cycles? I don't think so. and it is also easier to place + route + optimize for vivado.
AI disclaimer (heads-up for more than inline autocomplete)
No AI here