Open
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Contributor
|
Thanks, that's quite a bit of effort! Was 25.11 too old too? |
Contributor
Author
|
I didn't test 25.11 to be honest, I didn't see the direct benefit of linking to a 25.xx release as those are essentially just snapshots of nixos-unstable in November and get marked as deprecated 6 months later anyways. |
Contributor
|
It makes it a little bit easier for us to upgrade + it communicates a bit better where we're at. I.e. for the former, we've been behind for a year before, and I've found an 23.05 -> 23.11 -> 24.05 upgrade path definitely easier to do. But I admit this is very close to "just a preference" :-). |
Updates the Nix flake to include the latest unpublished versions of HLS. In specific, this updates HLS to version 2.13.0.0. Due to how HLS is set up, this required a few changes to accomplish: 1. Changed nixpkgs from nixos-25.05 to nixos-unstable. HLS required newer packages than those available in 25.05. 2. Due to the newer version of nixpkgs, some packages have been renamed/removed. Notably the python3Full has been removed. See the comment in the code. 3. Included the HLS source as a flake input, rather than a hardcoded source inside of the flake
Contributor
Author
|
I have changed it to 25.11 as the required versions are available on the 25.11 release :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the Nix flake to include the latest unpublished versions of HLS. In specific, this updates HLS to version 2.13.0.0.
Due to how HLS is set up, this required a few changes to accomplish: