Merge pull request #2173 from bitshares/pr-optimize-account-update

Improve performance for account_update
bitshares · May 10, 2020 · 784af1b · 784af1b
2 parents fde2aa4 + 73ddfcc
commit 784af1b
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 9 deletions.
diff --git a/libraries/chain/account_evaluator.cpp b/libraries/chain/account_evaluator.cpp
@@ -283,15 +283,15 @@ void_result account_update_evaluator::do_apply( const account_update_operation&
    // update account statistics
    if( o.new_options.valid() )
    {
-      d.modify( acnt->statistics( d ), [&]( account_statistics_object& aso )
+      if ( o.new_options->voting_account != acnt->options.voting_account
+           || o.new_options->votes != acnt->options.votes )
       {
-         if(o.new_options->is_voting() != acnt->options.is_voting())
-            aso.is_voting = !aso.is_voting;
-
-         if((o.new_options->votes != acnt->options.votes ||
-               o.new_options->voting_account != acnt->options.voting_account))
+         d.modify( acnt->statistics( d ), [&d,&o]( account_statistics_object& aso )
+         {
+            aso.is_voting = o.new_options->is_voting();
             aso.last_vote_time = d.head_block_time();
-      } );
+         } );
+      }
    }
 
    // update account object

diff --git a/libraries/chain/include/graphene/chain/account_object.hpp b/libraries/chain/include/graphene/chain/account_object.hpp
@@ -73,9 +73,9 @@ namespace graphene { namespace chain {
 
          bool has_cashback_vb = false; ///< redundantly store this for better maintenance performance
 
-         bool is_voting = false; ///< redundately store whether this account is voting for better maintenance performance
+         bool is_voting = false; ///< redundately store "if this account is voting" for better maintenance performance
 
-         time_point_sec last_vote_time; // add last time voted
+         time_point_sec last_vote_time; ///< last time voted
 
          /// Whether this account owns some CORE asset and is voting
          inline bool has_some_core_voting() const