This repository has been archived by the owner on Jan 22, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 147
3.0.x #280
Open
jayesh6696
wants to merge
177
commits into
master
Choose a base branch
from
3.0.x
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
3.0.x #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and removed empty tests.
- client was trying to create objects from unix timestamps with millisecond resolution - added a test to ensure these time-based objects are always in the past
Fixed invoice, expiration, and current time error
- Please note that the integration tests won't work with Symfony 3 due to Behat not supporting this version yet. - Unit tests are function with both Symfony 2.x or 3.0
…ment urls returned for an invoice
added new test to make sure payment urls are accessed correctly
…voice is already paid
Adding paymentUrls to Invoices
- Model classes will/should test types on mutators, a sane model is calling is_numeric followed by floatval for float types Rationale: Instantiators of models should take care to construct fields of the appropriate type, but model's should have a bit of checking as well for safety.
Update Configuration Doc Links
fix timezone ids for case-sensitive systems
Bug/field types
Remove Outdated Link
- should respect that numbers coming from the api might not have decimal points at all, but they are still valid
- should respect that numbers coming from the api might not have decimal points at all, but they are still valid
checkPriceAndCurrency
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[po;l[po[po[p