Fix ESLint not being able to run in worktrees#829
Draft
123mpozzi wants to merge 1 commit intodevelopmentfrom
Draft
Fix ESLint not being able to run in worktrees#829123mpozzi wants to merge 1 commit intodevelopmentfrom
123mpozzi wants to merge 1 commit intodevelopmentfrom
Conversation
123mpozzi
changed the title
123mpozzi
requested review from
rolandkakonyi
and removed request for
rolandkakonyi
Contributor
Author
|
Re-turning to draft since there are many violations to the new rule: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ESLint was not working properly under some conditions, like when working in git worktrees.
ESLint now resolves config locally and correctly evaluates its rules across the module.
Changes
root: truein root ESLint config (.eslintrc.js) to prevent inheriting parent ESLint configs (e.g. if running in a worktree with a parent git repo)@typescript-eslint/no-floating-promisesas error to catch un-awaited promise calls (would have caught Fix valid FairPlay could fail due to Source not waiting for DRM initialization #828 )parserOptionsoverride with so type-aware rules (like no-floating-promises) run with the correct TS runnerChecklist
CHANGELOGentry - no need, dev-specific