Add Android enableDrmLicenseRenewRetry TweakConfig flag.#826
Conversation
|
|
…RenewRetry' into feature/android_enableDrmLicenseRenewRetry # Conflicts: # android/src/main/java/com/bitmovin/player/reactnative/converter/JsonConverter.kt
…Retry # Conflicts: # CHANGELOG.md
…Retry # Conflicts: # CHANGELOG.md
There was a problem hiding this comment.
Pull request overview
This PR exposes the enableDrmLicenseRenewRetry TweaksConfig flag from the Android SDK to the React Native SDK, allowing developers to configure DRM license renewal retry behavior for long-running playback sessions.
Changes:
- Added
enableDrmLicenseRenewRetryproperty to TypeScript TweaksConfig interface - Modified Kotlin converter to handle the immutable
enableDrmLicenseRenewRetryproperty via constructor initialization - Updated CHANGELOG to document the new Android feature
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/tweaksConfig.ts | Added TypeScript type definition and JSDoc for the new enableDrmLicenseRenewRetry flag |
| android/src/main/java/com/bitmovin/player/reactnative/converter/JsonConverter.kt | Refactored toTweaksConfig() to initialize TweaksConfig with constructor parameter when enableDrmLicenseRenewRetry is provided |
| CHANGELOG.md | Documented the new TweaksConfig option under "Added" section |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
krocard
left a comment
There was a problem hiding this comment.
Looks good. Please use the builder to better scale
Description
Expose enableDrmLicenseRenewRetry from Android SDK into React Native SDK.
Changes
JsonConverter.kthas been changed in order to expose required API property.tweaksConfig.tshas been changed in order to reflect the changes on TypeScript types side.Checklist
CHANGELOGentry