Skip to content

Fixed bug reported #546 #548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fixed bug reported #546 #548

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
627a04f
Fixed bug reported #546
jcbit Jun 21, 2020
ffc5dcb
Update ws2.js
jcbit Jun 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/transports/ws2.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ const CbQ = require('cbq')
const _Throttle = require('lodash.throttle') // eslint-disable-line
const _isArray = require('lodash/isArray')
const _isEmpty = require('lodash/isEmpty')
const _isUndefined = require('lodash/isUndefined')
const _isString = require('lodash/isString')
const _isNumber = require('lodash/isNumber')
const _includes = require('lodash/includes')
Expand Down Expand Up @@ -1244,7 +1245,7 @@ class WSv2 extends EventEmitter {
for (let k = 0; k < filterIndices.length; k++) {
filterValue = filter[filterIndices[k]]

if (_isEmpty(filterValue) || filterValue === '*') {
if (_isUndefined(filterValue) || filterValue === '*') {
continue
}

Expand Down